Skip to content

feat: Implement Outlook Calendar Cache with Microsoft Graph Change No… #22120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

harshith-eth
Copy link

@harshith-eth harshith-eth commented Jun 28, 2025

…tifications

  • Added caching support to Office365CalendarService
  • Created MicrosoftGraphSubscriptionService for webhook management
  • Added webhook endpoint for Microsoft Graph notifications
  • Updated schema to support Microsoft Graph subscriptions
  • Added tests for the implementation

Fixes #21050

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Added caching for Outlook/Office 365 calendar availability and real-time updates using Microsoft Graph change notifications. This reduces API calls and keeps calendar data fresh.

  • New Features
    • Cached busy times for Outlook calendars to improve performance.
    • Webhook endpoint and subscription service for Microsoft Graph notifications.
    • Automatic cache invalidation and refresh when calendar events change.
    • Updated database schema to store Microsoft Graph subscription info.

…tifications

- Added caching support to Office365CalendarService
- Created MicrosoftGraphSubscriptionService for webhook management
- Added webhook endpoint for Microsoft Graph notifications
- Updated schema to support Microsoft Graph subscriptions
- Added tests for the implementation

Fixes calcom#21050
@harshith-eth harshith-eth requested review from a team as code owners June 28, 2025 09:27
Copy link

vercel bot commented Jun 28, 2025

@harshith-eth is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 28, 2025
@graphite-app graphite-app bot requested a review from a team June 28, 2025 09:27
@github-actions github-actions bot added $500 calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Jun 28, 2025
@dosubot dosubot bot added the webhooks area: webhooks, callback, webhook payload label Jun 28, 2025
Copy link

graphite-app bot commented Jun 28, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (06/28/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 2 issues across 6 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

credentialId: true,
externalId: true,
integration: true,
eventTypeId: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventTypeId is selected from the database but never used later, resulting in unnecessary data transfer.

const validationToken = query.validationToken;

if (validationToken) {
log.debug("Responding to Microsoft Graph validation", { validationToken });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule violated: Avoid Logging Sensitive Information

  Logs the Microsoft Graph `validationToken`, which is an authentication token and should not be written to logs per "Avoid Logging Sensitive Information" rule.
Suggested change
log.debug("Responding to Microsoft Graph validation", { validationToken });
log.debug("Responding to Microsoft Graph validation");

- Remove unused eventTypeId field from selectedCalendar query
- Remove sensitive validationToken from debug logs
- Fix TypeScript any type warning
@anikdhabal anikdhabal added the Medium priority Created by Linear-GitHub Sync label Jul 4, 2025
@kart1ka
Copy link
Contributor

kart1ka commented Jul 16, 2025

Type checks and tests seem to be failing. Can you pls address them?

@kart1ka kart1ka marked this pull request as draft July 16, 2025 15:24
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 31, 2025
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty A bounty on Algora.io calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync Stale teams area: teams, round robin, collective, managed event-types webhooks area: webhooks, callback, webhook payload $500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outlook Cache – Bounty-to-Hire
4 participants