Skip to content

fix: allow hosts to cancel bookings when disableCancelling is enabled #22310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

naaa760
Copy link

@naaa760 naaa760 commented Jul 7, 2025

What does this PR do?

  • Fixes issue where the "Disable Cancelling" feature incorrectly prevented hosts from canceling their own bookings. Now only attendees are blocked from canceling when this setting is enabled, while hosts/owners retain the ability to cancel bookings.

Fixes #22271

How should this be tested?

  • Create an event type with "Disable Cancelling" enabled

  • Book an appointment as an attendee

  • Try to cancel as the host/owner - should succeed

  • Try to cancel as the attendee - should be blocked

  • Test with team event types to verify host permissions work correctly

  • Expected: Hosts can always cancel, attendees cannot when feature is disabled.


Summary by cubic

Hosts can now cancel bookings even when "Disable Cancelling" is enabled. Only attendees are blocked from cancelling in this mode.

@naaa760 naaa760 requested a review from a team as a code owner July 7, 2025 20:37
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nehaaaa8 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

vercel bot commented Jul 7, 2025

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jul 7, 2025
@graphite-app graphite-app bot requested a review from a team July 7, 2025 20:37
@github-actions github-actions bot added Public 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jul 7, 2025
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jul 7, 2025
Copy link

graphite-app bot commented Jul 7, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/07/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 1 file and found no issues. Review PR in cubic.dev.

@anikdhabal
Copy link
Contributor

Hey @naaa760 thanks for your work. But we need the changes in other places aswell. This pr doing it correctly:- #22281

@anikdhabal anikdhabal closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI Public
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable cancellation feature disables the option for the host as well
3 participants