apps/api/v1/lib/audit-log.service.ts (1)

9-9: Fix typo in comment.

The comment contains a typo: "Expty" should be "Empty".

-    // Returning Expty array for now
+    // Returning Empty array for now

apps/api/v1/lib/helpers/audit-log.ts (1)

4-6: Consider function naming convention and utility.

The function name EmitAuditLogEvent uses PascalCase, which is typically reserved for classes/constructors in JavaScript/TypeScript. Consider using camelCase. Also, evaluate if this wrapper function adds sufficient value or if direct service calls would be more appropriate.

-export async function EmitAuditLogEvent(event: AuditLogEvent) {
+export async function emitAuditLogEvent(event: AuditLogEvent) {
   await AuditLogService.logEvent(event);
 }

Alternatively, consider whether this wrapper is necessary or if calling AuditLogService.logEvent directly would be more straightforward.

apps/api/v1/pages/api/audit-logs/_get.ts (2)

19-19: Remove unnecessary optional chaining.

The optional chaining operator (?.) is unnecessary since AuditLogService.getEvents is a defined method. This could indicate uncertainty about the API or be a remnant from development.

-    const events: AuditLogEvent[] = await AuditLogService.getEvents?.(filter);
+    const events: AuditLogEvent[] = await AuditLogService.getEvents(filter);

---

18-26: Consider more specific error handling.

While the current error handling is functional, you might consider logging the original error for debugging purposes while still providing a clean response to the client.

   try {
     const events: AuditLogEvent[] = await AuditLogService.getEvents(filter);
     return res.status(200).json({ events });
   } catch (error) {
+    console.error("Error fetching audit logs:", error);
     throw new HttpError({
       statusCode: 500,
       message: "Failed to fetch audit logs",
     });
   }

apps/api/v1/pages/api/audit-logs/_post.ts (1)

10-16: Consider more robust type validation.

While the current validation checks for object presence, consider adding more specific type validation for the request body to ensure it matches the expected structure more closely.

   const body = req.body as Partial<AuditLogEvent>;
-  if (!body || typeof body !== "object") {
+  if (!body || typeof body !== "object" || Array.isArray(body)) {
     throw new HttpError({
       statusCode: 400,
       message: "Invalid/Missing JSON body",
     });
   }

apps/api/v1/lib/types.ts (1)

149-150: Consider improving comment formatting and expanding action types.

The comment format should be consistent with the rest of the file. Also, consider if the current action types cover all necessary team audit scenarios.

-//Audit Logs for Teams
+// Audit Logs for Teams

Additionally, you might want to consider adding more specific actions like "EDIT", "INVITE", "REMOVE_MEMBER", etc., based on your team management requirements.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

apps/api/v1/lib/helpers/audit-log.ts (1)

4-6: Consider using camelCase for function names and add error handling documentation.

The function name EmitAuditLogEvent uses PascalCase, which is unconventional for function names in JavaScript/TypeScript. Consider renaming to emitAuditLogEvent to follow standard naming conventions.

Additionally, since this function doesn't handle errors from AuditLogService.logEvent, consider documenting that errors will propagate to the caller.

-export async function EmitAuditLogEvent(event: AuditLogEvent) {
+/**
+ * Emits an audit log event. Errors from the underlying service will propagate to the caller.
+ */
+export async function emitAuditLogEvent(event: AuditLogEvent) {
   await AuditLogService.logEvent(event);
 }

apps/api/v1/lib/audit-log.service.ts (1)

8-11: Fix typo in comment.

There's a typo in the comment on line 9.

-    // Returning Expty array for now
+    // Returning Empty array for now

apps/api/v1/pages/api/audit-logs/_get.ts (2)

19-19: Remove unnecessary optional chaining.

The optional chaining operator (?.) is unnecessary here since getEvents is a defined method on the AuditLogService object.

-    const events: AuditLogEvent[] = await AuditLogService.getEvents?.(filter);
+    const events: AuditLogEvent[] = await AuditLogService.getEvents(filter);

---

18-26: Consider improving error handling to preserve error details.

The current error handling catches all errors and throws a generic 500 error, which might mask important error details useful for debugging. Consider either removing the try-catch block to let defaultResponder handle errors, or preserving the original error details.

Option 1 - Remove try-catch and let defaultResponder handle errors:

-  try {
-    const events: AuditLogEvent[] = await AuditLogService.getEvents?.(filter);
-    return res.status(200).json({ events });
-  } catch (error) {
-    throw new HttpError({
-      statusCode: 500,
-      message: "Failed to fetch audit logs",
-    });
-  }
+  const events: AuditLogEvent[] = await AuditLogService.getEvents(filter);
+  return res.status(200).json({ events });

Option 2 - Preserve original error details:

   } catch (error) {
+    console.error("Failed to fetch audit logs:", error);
     throw new HttpError({
       statusCode: 500,
-      message: "Failed to fetch audit logs",
+      message: `Failed to fetch audit logs: ${error instanceof Error ? error.message : 'Unknown error'}`,
     });
   }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro