Skip to content

fix: improve ics app availability checks with multiple calendars, and recurring or cancelled events #22611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: improve ics app availability checks with multiple calendars, and recurring or cancelled events #22611

wants to merge 6 commits into from

Conversation

rubenbupe
Copy link

@rubenbupe rubenbupe commented Jul 17, 2025 •
edited
Loading

What does this PR do?

Fixes ICS availability logic for scenarios involving multiple calendars, recurring events, and cancelled events.

Background:
While using the ICS integration with Proton Calendar, I encountered “ghost events” that blocked my schedule unexpectedly. Upon investigation, I found that the availability check was also processing calendars that were not selected under the "Check for conflicts" section. Additionally, this led me to discover further issues related to how recurring and cancelled events were handled.

This PR improves ICS calendar feed processing by:

  • Checking availability only for the selected calendars
  • Correctly iterating recurring events: previously, recurring events would cause your availability to be marked as unavailable starting from the beginning of the availability window, rather than from the event’s actual start date
  • Ignoring cancelled events
  • Avoid duplication of recurring event exceptions

This may be related to bugs involving “ghost events,” as described in:

Visual Demo

Image Demo:

I have configured two calendars with the ICS app, which are the two you can see in the picture below. Only calendar 2 (pink) is selected in the “Check for conflicts” section.

Reference calendars:

Proton calendars
calendars
Before fix After fix
before after

Mandatory Tasks

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A. I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.
    • I have not added automated tests since I could not find existing tests for this app

How should this be tested?

  1. Add two calendars using the ICS app. You can use the sample calendars shown above.
  2. In the “Check for conflicts” section, select only one of the calendars (preferably Calendar 2, since it contains a cancelled event).
  3. Attempt to book a meeting with yourself from another browser.
    • Before the fix: Your availability will be blocked by events from both calendars, including cancelled events.
    • After the fix: Your availability should only be affected by non-cancelled events from Calendar 2 (the selected calendar). Events from the unselected calendar and cancelled events should not impact your availability.

@rubenbupe rubenbupe requested a review from a team as a code owner July 17, 2025 22:24
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot requested a review from a team July 17, 2025 22:24
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jul 17, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025 •
edited
Loading

Walkthrough

The getAvailability method in the ICSFeedCalendarService class was updated to use dayjs objects for defining date range boundaries instead of ISO strings. Calendar filtering now includes only those with URLs matching the selected calendars' external IDs. Event processing was modified to ignore events with a recurrence-id property and those with a status of "CANCELLED." The creation of ICAL.Event instances was moved earlier, and recurring event iteration now starts at the later of the event start or availability range start, using consistent range checks with rangeStart and rangeEnd. No changes were made to exported or public entity signatures.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/app-store/ics-feedcalendar/lib/CalendarService.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37d845c and 7da94bb.

📒 Files selected for processing (1)
  • packages/app-store/ics-feedcalendar/lib/CalendarService.ts (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/app-store/ics-feedcalendar/lib/CalendarService.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Install dependencies / Yarn install & cache
  • GitHub Check: Security Check
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2025

@rubenbupe is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 17, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/17/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the 🐛 bug Something isn't working label Jul 17, 2025
@rubenbupe rubenbupe changed the title fix(ics): improve availability checks with multiple calendars, and recurring or cancelled events fix: improve ics app availability checks with multiple calendars, and recurring or cancelled events Jul 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenbupe @CLAassistant