Skip to content

fix: moved bookings folder #22620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: moved bookings folder #22620

wants to merge 3 commits into from
+36 −0

Conversation

romitg2
Copy link
Contributor

@romitg2 romitg2 commented Jul 18, 2025

What does this PR do?

fixed similar to : #21430

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2025

@romitg2 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 18, 2025 •
edited
Loading

Walkthrough

A new Playwright end-to-end test was introduced within the "GTM container" test suite in the booking pages test file. This test automates the process of logging in a user, navigating to an event type page, selecting a future time slot, and completing a booking. After confirming the booking, the test verifies that Google Tag Manager scripts, noscript iframes, and related JavaScript objects (window.dataLayer, window.gtag) are not present on the booking confirmation page. This addition expands the test coverage for GTM presence across different booking-related pages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ceecd0 and 27ca728.

📒 Files selected for processing (1)
  • apps/web/playwright/booking-pages.e2e.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/playwright/booking-pages.e2e.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Install dependencies / Yarn install & cache
  • GitHub Check: Codacy Static Code Analysis
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jul 18, 2025
@graphite-app graphite-app bot requested a review from a team July 18, 2025 08:59
@romitg2 romitg2 changed the title moved bookings folder fix: moved bookings folder Jul 18, 2025
@github-actions github-actions bot added booking-page area: booking page, public booking page, booker consumer 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Jul 18, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 18, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/18/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Jul 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

E2E results are ready!

@kart1ka
Copy link
Contributor

kart1ka commented Jul 18, 2025

Hey @romitg2, Thanks for the PR. Pls attach a loom video showing your fix. A test seems to be failing. Can you pls address that as well?

@romitg2
Copy link
Contributor Author

romitg2 commented Jul 18, 2025 •
edited
Loading

Hey @romitg2, Thanks for the PR. Pls attach a loom video showing your fix. A test seems to be failing. Can you pls address that as well?

Hi, @kart1ka there isn't any change to show as GTM is not injected in local setup, you can refer to://github.com//issues/21430 issue's PR description for how this solves the issue.

and most probably some flacky test case is failing (getting timed out), and nothing related to changes in this PR.

I ran test of failing file embed-iframe.test.ts locally and it's passing.

Screenshot 2025-07-18 at 9 15 13 PM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Aug 2, 2025
@github-actions github-actions bot removed the Stale label Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright booking-page area: booking page, public booking page, booker community Created by Linear-GitHub Sync consumer 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent loading of dashboard GTM container on booking success page
3 participants
@romitg2 @kart1ka @emrysal