feat: implement automatic event type reassignment when user attributes change #22706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s change - Add eventTypeAttributeReassignment.ts with centralized logic for updating event type hosts based on attribute changes - Hook into assignUserToAttribute.handler.ts to trigger reassignment after individual attribute updates - Hook into assignValueToUser.ts to trigger reassignment after bulk attribute updates - Add reassignEventTypes.handler.ts for manual bulk reassignment via tRPC - Use zod validation for type-safe JsonValue to AttributesQueryValue conversion - Preserve existing host settings (priority, weight, scheduleId) when reassigning - Add comprehensive error handling and logging Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement automatic event type reassignment when user attributes change
Summary
This PR implements automatic event type host reassignment when user attributes are updated. Previously, when attributes were assigned to users, event types using attribute-based filtering (
assignRRMembersUsingSegment) would not automatically update their host assignments to reflect the new attribute values.Key Changes:
eventTypeAttributeReassignment.tswith centralized logic for finding and updating event types based on attribute changesassignUserToAttribute.handler.ts) and bulk (assignValueToUser.ts) attribute assignment flowsreassignEventTypesfor manual bulk reassignmentReview & Testing Checklist for Human
Recommended Test Plan:
assignRRMembersUsingSegment: trueand attribute filter queriesDiagram
%%{ init : { "theme" : "default" }}%% graph TD AssignUser["assignUserToAttribute.handler.ts<br/>(Individual Updates)"]:::minor-edit AssignBulk["assignValueToUser.ts<br/>(Bulk Updates)"]:::minor-edit Core["eventTypeAttributeReassignment.ts<br/>(Core Logic)"]:::major-edit Manual["reassignEventTypes.handler.ts<br/>(Manual Trigger)"]:::major-edit Router["_router.ts<br/>(tRPC Endpoint)"]:::minor-edit FindLogic["findTeamMembersMatchingAttributeLogic<br/>(Existing Logic)"]:::context EventTypes["EventType Database<br/>(Host Assignments)"]:::context AssignUser -->|"calls reassignEventTypesBasedOnAttributes"| Core AssignBulk -->|"calls reassignEventTypesBasedOnAttributes"| Core Manual -->|"calls reassignEventTypesBasedOnAttributes"| Core Router -->|"exposes endpoint"| Manual Core -->|"uses for matching logic"| FindLogic Core -->|"updates host assignments"| EventTypes subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Link to Devin run: https://app.devin.ai/sessions/48b698274b8b4407baf83267091974d3
Requested by: @joeauyeung