feat: migrate OrganizationOnboarding.logo to use avatars table #22747
+235
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logoUrl field to OrganizationOnboarding schema - Mark logo field as deprecated for backward compatibility - Update handlers to process base64 logo data using uploadLogo - Modify createOrganizationFromOnboarding to prefer logoUrl - Update onboarding store to handle logoUrl - Ensure all organization creation flows use avatar system Co-Authored-By: zomars@cal.com <zomars@me.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Add comprehensive test suite for logo migration functionality - Test base64 logo processing using uploadLogo and avatar system - Verify preference for logoUrl over legacy logo field - Test handling of non-base64 data and null values - Ensure backward compatibility with deprecated logo field - Fix OrganizationRepository to properly save logoUrl field - Move logo processing after organization creation for correct teamId Co-Authored-By: zomars@cal.com <zomars@me.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
- Add logoUrl: null to test expectations after schema migration - Handle invitedMembers: undefined in admin override tests - Ensure tests match actual OrganizationPaymentService behavior Co-Authored-By: zomars@cal.com <zomars@me.com>
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: migrate OrganizationOnboarding.logo to use avatars table
Summary
This PR migrates the
OrganizationOnboarding.logocolumn from storing base64 image data directly to using the existing avatar system that stores images in theavatarstable and returns URLs. This is an incremental migration that:logoUrlfield toOrganizationOnboardingschemalogofield as deprecated for backward compatibilityuploadLogologoUrlwhile falling back tologoThe migration follows the same pattern used by teams and organizations for logo handling, moving away from storing large base64 strings directly in the database.
Review & Testing Checklist for Human
logoUrlcolumn without issues and can be safely deployed to productionRecommended Test Plan:
logoUrlis populated and points to avatar systemDiagram
%%{ init : { "theme" : "default" }}%% graph TD UI["Organization Creation UI"] Store["onboardingStore.ts"]:::minor-edit CreatePayment["createWithPaymentIntent.handler.ts"]:::major-edit CreateSelf["createSelfHosted.handler.ts"]:::major-edit PaymentService["OrganizationPaymentService.ts"]:::minor-edit CreateOrg["createOrganizationFromOnboarding.ts"]:::major-edit Repository["organizationOnboarding.ts"]:::minor-edit Schema["schema.prisma"]:::major-edit AvatarSystem["avatar.ts"]:::context Database[("Database<br/>OrganizationOnboarding<br/>+ Avatar tables")]:::context UI -->|"logo upload"| Store Store -->|"logo data"| CreatePayment Store -->|"logo data"| CreateSelf CreatePayment -->|"process payment"| PaymentService CreatePayment -->|"base64 detection<br/>& upload"| AvatarSystem CreateSelf -->|"base64 detection<br/>& upload"| AvatarSystem CreatePayment -->|"create org"| CreateOrg CreateSelf -->|"create org"| CreateOrg CreateOrg -->|"save data"| Repository Repository -->|"persist"| Database AvatarSystem -->|"store image"| Database PaymentService -->|"update onboarding"| Repository subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
logofield as deprecated to maintain backward compatibilityuploadLogofunction handles storing images in the avatars table and returning URLsLink to Devin run: https://app.devin.ai/sessions/b56ecd2b3f7b42529ba4546f99d0c221
Requested by: @zomars