fix: center-align timezone and edit availability button on mobile layout #22760
Conversation
|
@sahitya-chandra is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes modify the styling of the container and elements within the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx (1)
262-265: Minor redundancy & consistency nitpick – duplicateditems-centerand mismatched pattern with sibling component
items-centeris applied twice (items-center+sm:items-center).
Because the base class already covers all break-points, keeping thesm:variant is unnecessary noise.
Also,EventTypeRestrictionScheduleDetails(same file, line 388) still usesjustify-center, so the two panels now behave differently on mobile.-<div className="bg-muted border-subtle flex flex-col items-center gap-2 rounded-b-md border p-6 sm:flex-row sm:items-center sm:justify-between"> +<div className="bg-muted border-subtle flex flex-col items-center gap-2 rounded-b-md border p-6 sm:flex-row sm:justify-between">While at it, consider mirroring the same
items-centerchange (and optionaltext-center) in the restriction-schedule block for visual consistency across both panels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code. Functions like .add, .diff, .isBefore, and .isAfter are slow, especially in timezone mode. Prefer .utc() for better performance. Where possible, replace with native Date and direct .valueOf() comparisons for faster execution. Recommend using native methods or Day.js .utc() consistently in hot paths like loops.
Files:
packages/features/eventtypes/components/tabs/availability/EventAvailabilityTab.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Install dependencies / Yarn install & cache
- GitHub Check: Codacy Static Code Analysis
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/27/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (07/27/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (07/28/25)1 label was added to this PR based on Keith Williams's automation. |
|
@Devanshusharma2005 checks have now passed... |
E2E results are ready! |
What does this PR do?
Before:
After:
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist