fix: CSV generation from insights returns empty results #22775

anikdhabal · 2025-07-28T11:53:43Z

What does this PR do?

Fixes CAL-6162
Fixes #22765

vercel · 2025-07-28T11:53:49Z

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-07-28T11:53:50Z

"""

Walkthrough

The changes modify the authorization logic in two service files by generalizing the ownership/admin verification to work with either organization or team IDs, rather than only organization IDs. The buildAuthorizationConditions methods now dynamically determine the target entity (organization or team) and conditionally perform ownership/admin checks only when applicable, based on the scope and presence of a target ID. The isOrgOwnerOrAdmin method signature and implementation were updated to accept a generic targetId. The buildTeamAuthorizationCondition method was also tightened to validate the relationship between teams and organizations more strictly. Local variable caching and minor refactoring were applied for clarity.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Complexity label: Simple
Rationale: The changes are localized to two files, involve moderate logic refactoring, method signature updates, and improved conditional checks. The scope and impact are clear, with no extensive cross-cutting changes or high-complexity algorithms.

Assessment against linked issues

Objective	Addressed	Explanation
Fix CSV generation from insights returning empty results (CAL-6162, #22765)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were identified.
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ba420d and 56281a5.

📒 Files selected for processing (2)

packages/lib/server/service/insightsBooking.ts (3 hunks)
packages/lib/server/service/insightsRoutingBase.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

packages/lib/server/service/insightsBooking.ts
packages/lib/server/service/insightsRoutingBase.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Codacy Static Code Analysis

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2025-07-28T11:55:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/28/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/28/25)

1 label was added to this PR based on Keith Williams's automation.

eunjae-lee · 2025-07-28T12:58:41Z

@anikdhabal I made a little change regarding targetId but realized that there's still an error here (haven't tested it but surely it's an issue).

export const insightsBookingServiceOptionsSchema = z.discriminatedUnion("scope", [
  z.object({
    scope: z.literal("user"),
    userId: z.number(),
    orgId: z.number(),
  }),
  z.object({
    scope: z.literal("org"),
    userId: z.number(),
    orgId: z.number(),
  }),
  z.object({
    scope: z.literal("team"),
    userId: z.number(),
    orgId: z.number(),
    teamId: z.number(),
  }),
]);

The input schema assumes orgId will always be there, but in case of a team not within an org won't definitely have an orgId. So we need some changes regarding this.

I can revisit this a few hours later, but not right now. Feel free to continue if you'd like now.

fix: CSV generation from insights returns empty results

8fa83a2

graphite-app bot requested a review from a team July 28, 2025 11:53

keithwillcode added the core area: core, team members only label Jul 28, 2025

dosubot bot added insights area: insights, analytics 🐛 bug Something isn't working labels Jul 28, 2025

anikdhabal requested a review from eunjae-lee July 28, 2025 11:54

anikdhabal and others added 2 commits July 28, 2025 17:27

Merge branch 'main' into csv_issue

60840fd

update

96e4364

eunjae-lee previously approved these changes Jul 28, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Jul 28, 2025

anikdhabal enabled auto-merge (squash) July 28, 2025 12:01

emrysal marked this pull request as draft July 28, 2025 12:13

auto-merge was automatically disabled July 28, 2025 12:13
Pull request was converted to draft

anikdhabal mentioned this pull request Jul 28, 2025

fix: CSV generation from insights returns empty results #22771

Closed

3 tasks

anikdhabal dismissed eunjae-lee’s stale review via 1ba420d July 28, 2025 12:42

anikdhabal marked this pull request as ready for review July 28, 2025 12:42

anikdhabal enabled auto-merge (squash) July 28, 2025 12:42

fix type error

1ba420d

eunjae-lee previously approved these changes Jul 28, 2025

View reviewed changes

update targetId

56281a5

eunjae-lee dismissed their stale review via 56281a5 July 28, 2025 12:56

eunjae-lee approved these changes Jul 28, 2025

View reviewed changes

anikdhabal merged commit 9cd806f into calcom:main Jul 28, 2025
33 of 37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: CSV generation from insights returns empty results #22775

fix: CSV generation from insights returns empty results #22775

Uh oh!

anikdhabal commented Jul 28, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 28, 2025

Uh oh!

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

graphite-app bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

eunjae-lee commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

fix: CSV generation from insights returns empty results #22775

fix: CSV generation from insights returns empty results #22775

Uh oh!

Conversation

anikdhabal commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

vercel bot commented Jul 28, 2025

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

graphite-app bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

eunjae-lee commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

anikdhabal commented Jul 28, 2025 •

edited

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

graphite-app bot commented Jul 28, 2025 •

edited

Loading