-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix: filtering-logic #22816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: filtering-logic #22816
Conversation
@Pallava-Joshi is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change updates the attendee visibility logic for team-seated events. The Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Assessment against linked issues
Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/30/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (07/30/25)1 label was added to this PR based on Keith Williams's automation. |
Hi @Pallava-Joshi, Thanks for the PR. Can you pls attach a loom video showing your fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a loom to in order to check the changes made.
Screencast.From.2025-07-31.23-11-05.mp4Here's the loom video attached with the team members as:
|
@Devanshusharma2005 can you please check on the loom... thanks. |
@Pallava-Joshi Could you please attach a better video with explanation? We can not extract anything of value from this video. |
loom.mp4Thanks for the feedback! I’ve attached a clearer video 🔉 with a step-by-step explanation of the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pallava-Joshi I think there has been some confusion. The core issue is that the team admin/owners should be able to see the attendees even if they are not part of the booking (as neither host nor attendee) which currently is not the case.
Could you pls fix that?
… getPeriodStartDatesBetween utility (calcom#22913) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…2931) * refactor: move getTotalBookingDuration to BookingRepository - Move getTotalBookingDuration function from standalone file to BookingRepository class - Update all usage sites to call method through repository instance - Remove standalone function file packages/lib/server/queries/booking/index.ts - Add prisma import to util.ts for BookingRepository instantiation - Maintain exact same method signature and functionality Co-Authored-By: morgan@cal.com <morgan@cal.com> * fix: remove eslint-config-next to resolve TypeScript ESLint conflicts - Remove eslint-config-next dependency that was causing version conflicts - Resolves 'Class extends value undefined is not a constructor or null' errors - ESLint 'next' config issue appears to be pre-existing in main branch Co-Authored-By: morgan@cal.com <morgan@cal.com> * fixup! Merge branch 'main' into devin/move-getTotalBookingDuration-1754460208 * chore: bump platform libs --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: morgan@cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
…Settings atoms (calcom#22911) * feat: Implement callback pattern in handleFormSubmit of EventTypePlatformWrapper * feat: Implement callback pattern in handleFormSubmit of AvailabilitySettingsPlatformWrapper * docs: add handleFormSubmit callback documentation for EventType and AvailabilitySettings atoms * Update availability.tsx * chore:added changelog * update docs --------- Co-authored-by: Rajiv Sahal <sahalrajiv-extc@atharvacoe.ac.in>
* fix: make organizationId optional number type in BookerEmbed * feat: dont call useMe for embeds * useOAuthClient hook should re-run when url is set * feat: Remove `?orgId=0` from /public event query params --------- Co-authored-by: Rajiv Sahal <sahalrajiv-extc@atharvacoe.ac.in>
* chore: Move date range validation to zod, removing TRPCError * This is not a BAD_REQUEST but an internal error, should not happen * Add a check to ensure the given start time is before end time
* add: lib folder in tailwind config * move plainChat and contactForm from lib to components * Update tailwind-preset.js
…ttings/developer/webhooks/... RSC (calcom#21781)" (calcom#22963)
… link of the integration (calcom#22964) * fix * fix * chore
* doc: fixed the V2 api README file * chore
* added headless routing link to embed * Update apps/web/public/static/locales/en/common.json * Update apps/web/public/static/locales/en/common.json * fix: add missing headless embed type handlers to resolve TypeScript errors - Add headless handlers for react, react-atom, and HTML frameworks in EmbedCodes.tsx - Add headless case handling in EmbedTabs.tsx getEmbedTypeSpecificString function - Add embedCalOrigin parameter to HTML framework handlers for type consistency - All handlers return documentation comments directing users to headless routing docs Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * temp: enable IS_CALCOM for localhost testing Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * fix: change headless handlers to return null instead of documentation code Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * revert: remove temporary IS_CALCOM localhost change Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> * refactor: remove unnecessary parameter destructuring from headless embed handlers - Headless handlers now take no parameters since they only return null - Simplified function signatures to avoid unused parameter warnings - Maintains existing functionality while improving code clarity Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: hariom@cal.com <hariombalhara@gmail.com>
…22843) * added strict url validation with consistent Invalid URL error message * chore * Update schema.ts --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
* feat: toggle round robin booker org and team * chore: add changeset * dont hide in dev
calcom#22845) Co-authored-by: sean@cal.com <Sean@brydon.io> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: CarinaWolli <wollencarina@gmail.com>
…tion (calcom#22949) * refactor: convert getBusyTimes to service class with dependency injection - Create BusyTimesService following UserAvailabilityService pattern - Add DI tokens, module, and container setup for BusyTimesService - Update all usage locations to use service instead of direct function calls - Maintain existing function signatures for backward compatibility - Add legacy exports to ensure smooth transition - Update type references in trpc util to use service prototype - Fix linting issues by making legacy exports async with proper imports - All tests pass and type checking succeeds Co-Authored-By: morgan@cal.com <morgan@cal.com> * refactor: busy time service * fix: api v2 eslint plugins version mismatch * chore: bump platform libs * chore: bump platform libs * fix: missing di busyTimesModule in slots service --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: morgan@cal.com <morgan@cal.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com>
* chore: zoom waiting room setting * Update VideoApiAdapter.ts * Update VideoApiAdapter.ts
* Add logging to SAML endpoints * Update packages/features/auth/lib/next-auth-options.ts --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
…calcom#22972) * fix: prevent makeBodyVisible timeout from running after test teardown - Add timeout tracking to makeBodyVisible function to enable cleanup - Add vi.clearAllTimers() to test teardown to clear recursive timeouts - Prevents 'ReferenceError: document is not defined' in CI tests Fixes intermittent test failures where makeBodyVisible recursive timeout continues running after test environment is torn down. Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * simplify: use only vi.clearAllTimers() to fix timeout issue Based on code review feedback, test if vi.clearAllTimers() alone is sufficient without modifying makeBodyVisible function. - Reverted makeBodyVisible function changes - Kept only vi.clearAllTimers() in test teardown - Verified with multiple test runs and type checking Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* add Add Group button * add host groups to schema * UI for host groups * raname groups to hostGroups * schema update * show groups in assignment tab * add no group hosts to Group 1 * add dummy group for non group hosts * fix type errors * use two dimensional array for luckyUserPools * fix empty array * group RR hosts in handleNewBooking * improve logic for grouping lucky users * find all lucky users of all groups * allow several RR hosts on booking * clean up migrations * create helper function * group hosts for slots logic * add group logic to loading available slots * adding hosts to groups * add groupId to hostSchema * disable hosts from other groups * handle groups in checkedTeamSelect * fix adding hosts to groups * remove and add groups * show hosts if there are no groups * fixing adding first group with existing hosts * show groups empty groups correctly * UI upddate fixes * fix adding hosts to existing first host group * small fixes + code clean up * add availability fix with test * create new round-robin test file * disable reassignment * fix losing fixed hosts * fix updating weights and priorities * disable load balancing with Round Robin Groups * automatically disable load balancing in update handler * allRRHosts should only include hosts from same group * fix type errors * fix type error * fix tests * fix type error * remove undefined from groupId type * type changes * add tests for hostGroups * add tests for host groups * fixes * fix type errors with undefined groupId * remove seperate host groups prop * fix editing weights * remove console.log * code clean up * improve getAggregatedAvailability tests * throw error when no available hosts in a group * add fixme comment * create constant for DEFAULT_GROUP_ID * clean up code * mock default_group_id for unit tests * don't show fixed hosts in edit weights side bar * add DEFAULT_GROUP_ID to mock test-setup * remove unused index variable * code clean up * fix updating host groups * fix imports * add default_group_id to mocks * add uuid() to zod schema * remove unused code * fix singular translation key * remove unnessary !! * Revert formatting changes * add additional tests for bookingActions * use createMany * import DEFAULT_GROUP_ID for mocks * fix mocks * clean up EventTeamAssignmentTab * fix type errors in tests * fix mocks * remove constants.example.test.ts * fix type error * add missing groupId * fix margin * clean up empty host groups * fix constants mock * useCalback * use reduce * extract handlers into seperate functions * fix handler functions * fix border radius * fix type error in CheckForEmptyAssignment * fix type error --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
…es (calcom#22975) * chore: Add relation between a host and a membership for future cascades * Apply suggestion Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix: apply PBAC to routing form CRUD * apply permission checks to the UI * moving prisma call to repository [WIP] * rename repository and fix type error * update implementation * fix formMutation handler * remove unused import * revert some rename * add RolePermission for 'routingForm' * Revert "revert some rename" This reverts commit 0ef3114. * clean up PrismaRoutingFormRepository * fix unit test * remove no longer necessary code * fix type definition * explicit permission handling * do not disable un-editable routing form * fix: correct property name from readonly to readOnly in ListLinkItem - Fix TypeScript error in routing forms component - Change readonly={readOnly} to readOnly={readOnly} to match component interface - Resolves type check failure in CI Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com> --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…m#22028) * feat: filter embed query params from booking success redirects - Add filterEmbedParams option to getNewSearchParams function - Filter out embed, layout, embedType, and ui.color-scheme params when redirecting to external pages - Add comprehensive unit tests for bookingSuccessRedirect covering: - External redirects with and without parameter forwarding - Embed parameter filtering functionality - Internal redirects to booking pages - Booking parameter extraction - All tests pass and type checking succeeds Fixes calcom#20469 Co-Authored-By: hariom@cal.com <hariom@cal.com> * chore: retrigger CI checks Co-Authored-By: hariom@cal.com <hariom@cal.com> * chore: remove temporary CI retrigger file Co-Authored-By: hariom@cal.com <hariom@cal.com> * Handle a case --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: hariom@cal.com <hariom@cal.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
* fix: flaky e2e * fix: slugify url
* feat: cal ai self serve architecture * chore: add package * chore: update evnet controller * refactor: improvements * chore: rename * chore: type error and naming * chore: just set it to nul * chore: just set it to nul * chore: some more improvements * chore: packate version * fix: API v2 * chore: change name of files * chore: add select * chore: add missing teamId * chore: save progress * refactor: split into multiple services * refactor: make schema provider agonistic * chore: improvements * chore: * chore: remove duplicate files * chore: semicolon * chore: formatting * refactor: logging and error handling * chore: rename variable * refactor: use trpc error * chore: replace with HttpError * chore: remove from option * We need the enum and not just the type --------- Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: Kartik Saini <41051387+kart1ka@users.noreply.github.com>
|
What does this PR do?
This PR resolves an issue where team admins or owners were unable to view the attendees of team events with assigned seats unless they were the host. The update modifies the attendee filtering logic to grant visibility of all attendees to team admins/owners, while ensuring standard members can only see their own information.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Test Setup
Create a team with:
Create a team event with:
seatsShowAttendees
set tofalse
Have the regular member book a seat in that event.
Test Cases
Admin Test
/bookings
Member Test
/bookings
Success Page Test
Expected Outcome