fix: minor UI improvements for end of month design #22837

CarinaWolli · 2025-07-31T12:12:11Z

What does this PR do?

Tooltip only for the new month and not for the current month
No tooltip when hovering over disabled days

coderabbitai · 2025-07-31T12:12:24Z

Walkthrough

A new constant, showNextMonthDays, is introduced to encapsulate the condition isSecondWeekOver && !isCompact within the Days component of DatePicker.tsx. This constant replaces repeated conditional logic in two locations: where end-of-month rendering logic is applied and where the showMonthTooltip prop is set for the DayComponent. Additionally, the logic for displaying the month tooltip is refined to only show when the day is not disabled and belongs to a different month than the currently browsed month. No exported or public entity declarations are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

feat: Improving Booking Visibility at Month-End #22770: Refactored the DatePicker.tsx file to introduce the isCompact prop and modified calendar rendering logic for end-of-month views, which is directly built upon by the current PR’s changes to conditional logic and tooltip display.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cc7827 and f039bcd.

📒 Files selected for processing (1)

packages/features/calendars/DatePicker.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.tsx

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

packages/features/calendars/DatePicker.tsx

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

packages/features/calendars/DatePicker.tsx

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.{ts,tsx} : Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js `.utc()` in hot paths like loops

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Learnt from: alishaz-polymath
PR: calcom/cal.com#22304
File: packages/features/eventtypes/components/MultiplePrivateLinksController.tsx:92-94
Timestamp: 2025-07-16T06:42:27.024Z
Learning: In the MultiplePrivateLinksController component (packages/features/eventtypes/components/MultiplePrivateLinksController.tsx), the `currentLink.maxUsageCount ?? 1` fallback in the openSettingsDialog function is intentional. Missing maxUsageCount values indicate old/legacy private links that existed before the expiration feature was added, and they should default to single-use behavior (1) for backward compatibility.

📚 Learning: applies to **/*.{ts,tsx} : flag excessive day.js use in performance-critical code; prefer native dat...

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.{ts,tsx} : Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js `.utc()` in hot paths like loops

Applied to files:

packages/features/calendars/DatePicker.tsx

📚 Learning: in signup-view.tsx, when checking if redirecturl contains certain strings, using explicit && checks ...

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Applied to files:

packages/features/calendars/DatePicker.tsx

📚 Learning: in the multipleprivatelinkscontroller component (packages/features/eventtypes/components/multiplepri...

Learnt from: alishaz-polymath
PR: calcom/cal.com#22304
File: packages/features/eventtypes/components/MultiplePrivateLinksController.tsx:92-94
Timestamp: 2025-07-16T06:42:27.024Z
Learning: In the MultiplePrivateLinksController component (packages/features/eventtypes/components/MultiplePrivateLinksController.tsx), the `currentLink.maxUsageCount ?? 1` fallback in the openSettingsDialog function is intentional. Missing maxUsageCount values indicate old/legacy private links that existed before the expiration feature was added, and they should default to single-use behavior (1) for backward compatibility.

Applied to files:

packages/features/calendars/DatePicker.tsx

🔇 Additional comments (3)

packages/features/calendars/DatePicker.tsx (3)

197-197: LGTM: Good refactoring to eliminate code duplication.

The introduction of showNextMonthDays constant effectively encapsulates the repeated condition isSecondWeekOver && !isCompact, improving code maintainability and readability.

200-200: LGTM: Consistent usage of the new constant.

The replacement of the inline condition with showNextMonthDays maintains the same logic while improving code consistency.

342-342: LGTM: Enhanced tooltip logic aligns with PR objectives.

The refined tooltip logic correctly implements the PR requirements:

Shows tooltip only for next month days (showNextMonthDays && day.month() !== browsingDate.month())

Excludes disabled days (!disabled)

Ensures tooltip appears exclusively for the new month, not the current month

This change enhances the user experience by providing clearer and more relevant tooltip information as specified in the PR objectives.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/minor-UI-Improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-07-31T12:14:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Aug 4, 2025 2:45am
cal-eu	⬜️ Ignored (Inspect)			Aug 4, 2025 2:45am

graphite-app · 2025-07-31T12:15:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/31/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/04/25)

1 label was added to this PR based on Keith Williams's automation.

hbjORbj

LGTM

github-actions · 2025-08-04T03:05:06Z

E2E results are ready!

Workflow #70403.1 latest results

minor UI improvements

475a596

graphite-app bot requested a review from a team July 31, 2025 12:12

keithwillcode added consumer core area: core, team members only labels Jul 31, 2025

CarinaWolli marked this pull request as draft July 31, 2025 12:12

dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jul 31, 2025

revert classname changes

327da66

remove not needed code

f039bcd

CarinaWolli marked this pull request as ready for review July 31, 2025 12:18

CarinaWolli added the Medium priority Created by Linear-GitHub Sync label Jul 31, 2025

vercel bot deployed to Preview – dev July 31, 2025 12:56 View deployment

CarinaWolli enabled auto-merge (squash) August 1, 2025 07:44

hbjORbj approved these changes Aug 4, 2025

View reviewed changes

hbjORbj added the ready-for-e2e label Aug 4, 2025

Merge branch 'main' into fix/minor-UI-Improvements

cc8d0aa

CarinaWolli merged commit 852eb34 into main Aug 4, 2025
38 of 39 checks passed

CarinaWolli deleted the fix/minor-UI-Improvements branch August 4, 2025 03:02

vercel bot deployed to Preview – dev August 4, 2025 03:05 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: minor UI improvements for end of month design #22837

fix: minor UI improvements for end of month design #22837

CarinaWolli commented Jul 31, 2025

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

hbjORbj left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Uh oh!

fix: minor UI improvements for end of month design #22837

fix: minor UI improvements for end of month design #22837

Conversation

CarinaWolli commented Jul 31, 2025

What does this PR do?

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

hbjORbj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025

E2E results are ready!

Uh oh!

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Jul 31, 2025 •

edited

Loading

graphite-app bot commented Jul 31, 2025 •

edited

Loading