Fix: Update BTCPay Server currencies and fix dark mode bug #22887

TChukwuleta · 2025-08-04T13:58:23Z

What does this PR do?

This PR fixes comments for the BTCPay Server integration.
Cal.com integration btcpayserver/btcpayserver#6715 (comment)

With this in dark mode the price label is now visible and the price input text is also visible.

Includes more currencies that is supported by BTCPay server.

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

vercel · 2025-08-04T13:58:29Z

@TChukwuleta is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2025-08-04T13:58:33Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: Update BTCPay Server currencies and fix dark mode bug". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

CLAassistant · 2025-08-04T13:58:34Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anikdhabal
❌ TChukwuleta
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

graphite-app · 2025-08-04T14:00:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (08/04/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/04/25)

1 label was added to this PR based on Keith Williams's automation.

coderabbitai · 2025-08-04T14:05:26Z

Walkthrough

The changes update the user interface for entering a price in the EventTypeAppSettingsInterface component by restructuring the container layout, adding a visible label above the price input, and adjusting styling for dark mode compatibility and input width. Additionally, the currency options in the currencyOptions.ts module are expanded from a single USD entry to a comprehensive list of 27 currencies, with updated labels and inclusion of the Japanese Yen (JPY) as a zero-decimal currency. The zero-decimal currency logic is updated to recognize JPY, affecting currency conversion functions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

fix: BTCPayServer App - fixes #22928 #22933: Modifies the EventTypeAppSettingsInterface.tsx component to improve labeling and text color of the price input field, closely related to the UI changes in this PR.

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4babb0 and 5541f2f.

📒 Files selected for processing (1)

packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Install dependencies / Yarn install & cache

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2205d4 and 22ca6d6.

📒 Files selected for processing (2)

packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx (1 hunks)
packages/app-store/btcpayserver/lib/currencyOptions.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.ts

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

**/*.ts: For Prisma queries, only select data you need; never use include, always use select
Ensure the credential.key field is never returned from tRPC endpoints or APIs

Files:

packages/app-store/btcpayserver/lib/currencyOptions.ts

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

packages/app-store/btcpayserver/lib/currencyOptions.ts
packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx

**/*.tsx

📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Tests / Unit
GitHub Check: Type check / check-types

🔇 Additional comments (4)

packages/app-store/btcpayserver/lib/currencyOptions.ts (2)

32-32: LGTM! JPY correctly classified as zero-decimal currency.

Japanese Yen is properly classified as a zero-decimal currency, which aligns with standard financial practices where JPY amounts are expressed as whole numbers.

34-46: LGTM! Currency conversion functions handle new currencies correctly.

The conversion functions properly handle the expanded currency list, including the newly added JPY as a zero-decimal currency.

packages/app-store/btcpayserver/components/EventTypeAppSettingsInterface.tsx (2)

63-66: LGTM! Improved accessibility and layout.

The addition of an explicit label element with proper htmlFor attribute enhances accessibility for screen readers. The inline-block container and text-default class provide better layout and dark mode support, addressing the PR objective.

69-69: LGTM! Dark mode visibility fix implemented correctly.

The updated className with text-black dark:text-white properly addresses the dark mode visibility issue mentioned in the PR objectives, ensuring the price input text is visible in both light and dark themes.

packages/app-store/btcpayserver/lib/currencyOptions.ts

github-actions · 2025-08-04T20:13:44Z

E2E results are ready!

Workflow #71071.1 latest results

) * Update BTCPay Server currencies * fix type --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>

Update BTCPay Server currencies

22ca6d6

graphite-app bot requested a review from a team August 4, 2025 13:58

graphite-app bot added the community Created by Linear-GitHub Sync label Aug 4, 2025

TChukwuleta changed the title ~~Update BTCPay Server currencies and fix dark mode bug~~ Fix: Update BTCPay Server currencies and fix dark mode bug Aug 4, 2025

dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Aug 4, 2025

coderabbitai bot reviewed Aug 4, 2025

View reviewed changes

packages/app-store/btcpayserver/lib/currencyOptions.ts Outdated Show resolved Hide resolved

fix type

c4babb0

PeerRich previously approved these changes Aug 4, 2025

View reviewed changes

Merge branch 'main' into update_currencies

21a9a78

graphite-app bot added the ready-for-e2e label Aug 4, 2025

Merge branch 'main' into update_currencies

5541f2f

anikdhabal dismissed PeerRich’s stale review via 5541f2f August 8, 2025 05:32

anikdhabal approved these changes Aug 8, 2025

View reviewed changes

anikdhabal enabled auto-merge (squash) August 8, 2025 05:34

anikdhabal merged commit 86f6e8b into calcom:main Aug 8, 2025
28 of 35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Update BTCPay Server currencies and fix dark mode bug #22887

Fix: Update BTCPay Server currencies and fix dark mode bug #22887

Uh oh!

TChukwuleta commented Aug 4, 2025 •

edited

Loading

Uh oh!

vercel bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Aug 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Fix: Update BTCPay Server currencies and fix dark mode bug #22887

Fix: Update BTCPay Server currencies and fix dark mode bug #22887

Uh oh!

Conversation

TChukwuleta commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Visual Demo (For contributors especially)

Mandatory Tasks (DO NOT REMOVE)

Checklist

Uh oh!

vercel bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

Uh oh!

Uh oh!

TChukwuleta commented Aug 4, 2025 •

edited

Loading

github-actions bot commented Aug 4, 2025 •

edited

Loading

CLAassistant commented Aug 4, 2025 •

edited

Loading

graphite-app bot commented Aug 4, 2025 •

edited

Loading

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Aug 4, 2025 •

edited

Loading