packages/ui/components/list/List.tsx (2)

33-36: Fix invalid DOM nesting and remove dead href path in ListItem

• ListItemProps forbids href, yet ListItem still destructures/uses href and wraps a created
• in . This yields invalid HTML (
  > >
  • ) if href slips through at runtime and leaves dead code under type-safe usage.
  • Align implementation with the public type: render a plain
  • , drop the Link wrapper and href checks, and remove href from className logic.

  Apply this diff:

   export function ListItem(props: ListItemProps) {
  -  const { href, expanded, rounded = true, ...passThroughProps } = props;
  -
  -  const elementType = "li";
  +  const { expanded, rounded = true, ...passThroughProps } = props;
  
  -  const element = createElement(
  -    elementType,
  +  const element = createElement(
  +    "li",
       {
         ...passThroughProps,
         className: classNames(
           "items-center bg-default min-w-0 flex-1 flex border-neutral-200 p-4 sm:mx-0 md:border md:p-4 xl:mt-0 border-subtle",
           expanded ? "my-2 border" : "border -mb-px last:mb-0",
           // Pass rounded false to not round the corners -> Useful when used in list we can use roundedContainer to create the right design
           rounded ? "rounded-md" : "rounded-none",
           props.className,
  -        (props.onClick || href) && "hover:bg-muted"
  +        props.onClick && "hover:bg-muted"
         ),
         "data-testid": "list-item",
       },
       props.children
     );
  
  -  return href ? (
  -    <Link href={href}>
  -      {element}
  -    </Link>
  -  ) : (
  -    element
  -  );
  +  return element;
   }

  If you intended to keep link support on ListItem, invert the structure instead: keep

• as the container and place inside the
• . In that case, revert the prop to href: string, and do not wrap
• with .

  Also applies to: 38-41, 46-53, 59-66

  ---

  100-106: Remove deprecated passHref prop from all Link components

  Next.js 13+ no longer requires passHref. Please remove it project-wide.

  Affected locations:

  • packages/ui/components/list/List.tsx (lines 100–106)
  • packages/features/eventtypes/components/tabs/workflows/EventWorkfowsTab.tsx (line 142)
  • packages/features/ee/teams/pages/team-profile-view.tsx (line 194)
  • packages/features/ee/organizations/pages/settings/other-team-profile-view.tsx (line 301)

  Example diff for List.tsx:

  -      <Link
  -        passHref
  -        href={href}
  +      <Link
  +        href={href}
           className={classNames(
             "text-default flex-grow truncate text-sm",
             disabled ? "pointer-events-none cursor-not-allowed opacity-30" : ""
           )}>

  For links with a disabled state, consider adding accessibility attributes:

  -      <Link
  +      <Link
           href={href}
  +        aria-disabled={disabled || undefined}
  +        tabIndex={disabled ? -1 : undefined}

  After applying these changes, re-run:

  rg -n "<Link[^>]*passHref" --glob "**/*.tsx"

  to verify no remaining usages.

packages/ui/components/list/List.tsx (2)

116-118: Avoid manual substring + literal "..." for subHeading

Manual truncation harms accessibility and introduces embedded text that bypasses i18n. Prefer CSS truncation (truncate or line-clamp). If you need an ellipsis character, use the typographic ellipsis (…); if you must render text programmatically, route it via t() per guidelines.

Example refactor (single-line truncation):

-        <h2 className="min-h-4 mt-2 text-sm font-normal leading-none text-neutral-600">
-          {subHeading.substring(0, 100)}
-          {subHeading.length > 100 && "..."}
-        </h2>
+        <h2 className="mt-2 text-sm font-normal leading-none text-neutral-600 truncate">
+          {subHeading}
+        </h2>

If multi-line is desired, use Tailwind’s line-clamp-* utilities (ensure the plugin is enabled).

---

40-44: Minor: remove unnecessary elementType indirection

Since it’s always an li now, the local constant adds noise. Use "li" inline in createElement (as in the main fix above) or convert to JSX for readability.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro