chore: update ESLint configuration #22924
Conversation
|
@zhyd1997 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe ESLint configuration file Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.eslintrc.js (1)
3-5: Addroot: trueto prevent parent config bleed-through
Withoutroot: true, ESLint will continue walking up the directory tree and may pick up unexpected configs, re-introducing the CI inconsistencies this PR aims to fix.module.exports = { + root: true, extends: ["./packages/config/eslint-preset.js"], };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.eslintrc.js(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (2)
.eslintrc.js (2)
2-2: Good JSDoc annotation
The explicitLinter.Configtype improves IDE support and helps catch mis-typed fields early.
4-4: Double-check the preset path
The path now includes the.jsextension. Verify that the file on disk matches (eslint-preset.js) and is referenced consistently across the repo; otherwise ESLint resolution will fail, especially if the preset was previously published asindex.js,.cjs, etc.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/06/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (08/06/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (08/06/25)1 label was added to this PR based on Keith Williams's automation. |
|
/tip 25 |
|
Please visit Algora to complete your tip via Stripe. |
|
🎉🎈 @zhyd1997 has been awarded $25 by Cal.com, Inc.! 🎈🎊 |
Added a missing semicolon after the getUserAvailabilityService() call to maintain code consistency and prevent potential issues.
E2E results are ready! |
I just spent half an hour with ChatGPT, Codex, Copilot, Gemini 2.5 Pro, and Claude Code—and none of them made any sense. |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist