Skip to content

fix: fixed the estonian language on confirmation page #22936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

fix: fixed the estonian language on confirmation page #22936

merged 2 commits into from
Aug 6, 2025

Conversation

sahitya-chandra
Copy link
Contributor

@sahitya-chandra sahitya-chandra commented Aug 6, 2025 •
edited
Loading

What does this PR do?

Visual Demo (For contributors especially)

Screenshot from 2025-08-06 21-32-27

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025 •
edited
Loading

Walkthrough

The change updates the Estonian localization file (apps/web/public/static/locales/et/common.json) by modifying the translation for the key "who" from "WHO" to "Kes". No other keys or files are affected in this pull request.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Correct Estonian translations for fields on the confirmation page (#22935, CAL-6210) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b410316 and 91ba0e7.

📒 Files selected for processing (1)
  • apps/web/public/static/locales/et/common.json (1 hunks)
🔇 Additional comments (1)
apps/web/public/static/locales/et/common.json (1)

383-383: Translation update looks correct and consistent
Replacing "WHO" with "Kes" aligns the Estonian localisation with neighbouring keys ("Mida", "Millal", "Kus"), keeping the capitalised first letter style. No further action needed.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Aug 6, 2025
@graphite-app graphite-app bot requested a review from a team August 6, 2025 15:49
@sahitya-chandra sahitya-chandra marked this pull request as draft August 6, 2025 15:49
@github-actions github-actions bot added i18n area: i18n, translations Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Aug 6, 2025
@vercel Vercel
Copy link

vercel bot commented Aug 6, 2025

@sahitya-chandra is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 6, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (08/06/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/06/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the foundation label Aug 6, 2025
@anikdhabal anikdhabal marked this pull request as ready for review August 6, 2025 15:51
@sahitya-chandra sahitya-chandra changed the title fix: fixed the estonian languageon confirmation page fix: fixed the estonian language on confirmation page Aug 6, 2025
@anikdhabal anikdhabal merged commit b5a26bc into calcom:main Aug 6, 2025
74 of 80 checks passed
@sahitya-chandra sahitya-chandra deleted the cal-6210 branch August 6, 2025 16:52
Pallava-Joshi pushed a commit to Pallava-Joshi/cal.com that referenced this pull request Aug 8, 2025
@sahitya-chandra @Pallava-Joshi
fix: fixed the estonian languageon confirmation page (calcom#22936)
6592553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync foundation i18n area: i18n, translations Low priority Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

estonian language showing the wrong language on different fields of the confirmation page
3 participants
@sahitya-chandra @PeerRich @anikdhabal