Skip to content

Move pytest to a test dependency #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2020
Merged

Move pytest to a test dependency #213

merged 2 commits into from
Jan 28, 2020

Conversation

avanbrunt-cb
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code).
  • Linter has passed locally and any fixes were made for failures.
  • A self-review of the code has been done.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes (not tied to bugs/features)
  • Other (please describe):

What is the ticket or issue number?

Request made by email to dev-support@carbonblack.com

github issues recommended for easier tracking

Pull Request Description

Move pytest from install dependency to test dependency

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Manual test perform locally

abowersox-cb
abowersox-cb approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@abowersox-cb abowersox-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward.

@avanbrunt-cb avanbrunt-cb merged commit a0eaefe into master Jan 28, 2020
@avanbrunt-cb avanbrunt-cb deleted the test_dependencies branch January 28, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llyon-cb llyon-cb Awaiting requested review from llyon-cb

@kgarcia-cb kgarcia-cb Awaiting requested review from kgarcia-cb

@dly-cb dly-cb Awaiting requested review from dly-cb

2 more reviewers

@abowersox-cb abowersox-cb abowersox-cb approved these changes

@bvasil-cb bvasil-cb bvasil-cb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avanbrunt-cb @abowersox-cb @bvasil-cb