Skip to content

Conversation

dly-cb
Copy link
Contributor

@dly-cb dly-cb commented Apr 8, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code).
  • Linter has passed locally and any fixes were made for failures.
  • A self-review of the code has been done.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes (not tied to bugs/features)
  • Other (please describe):

What is the ticket or issue number?

Pull Request Description

Does this introduce a breaking change?

  • Yes
  • No

In CB Response 7.1 release, certain fields weren't allowed to be modified. We changed the api response to only send in valid fields that were allowed.

How Has This Been Tested?

Testing was done by creating a testing environment with response backend team (Antonio Herran) confirmed that the new changes worked on both CB Response 7.1 and CB Response 6.5.3.

Other information:

Copy link
Contributor

@avanbrunt-cb avanbrunt-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the missing changelog the change looks good to me

@dly-cb dly-cb merged commit 420fa05 into master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants