six.py replaced with 1.16 version and replaced readfp with read_file #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging. @kebringer-cb @avanbrunt-cb @emitreva-cb |
|
How was this tested manually? |
|
As suggested, did some manual testing on real test EDR. Working through issues. |
|
Quick Test Note: zeek@zeek-ubuntu:~/test3.12$ source venv/bin/activate
(venv) zeek@zeek-ubuntu:~/test3.12$ cat ~/.carbonblack/credentials.response
[default]
url = https://192.168.184.4
token = xxxxxxxxxx(masked)xxxxxxxxxx
ssl_verify = False
(venv) zeek@zeek-ubuntu:~/test3.12$ python3.12 --version
Python 3.12.0
(venv) zeek@zeek-ubuntu:~/test3.12$ python3.12 ~/cbapi-python/examples/response/feed_operations.py list | grep display_name
display_name : Bit9 Software Reputation Service Trust
display_name : Cb Reputation Threat
display_name : National Vulnerability Database
display_name : Carbon Black Advanced Threats Feed
display_name : Carbon Black Early Access Indicators Feed
display_name : Carbon Black Endpoint Visibility Feed
display_name : Carbon Black Endpoint Suspicious Indicators Feed
display_name : Carbon Black Abuse.ch
display_name : Carbon Black AlienVault
display_name : Carbon Black Banning Events
display_name : Carbon Black Community Feed
display_name : Carbon Black Detected EMET Events
display_name : Carbon Black Endpoint Tamper Detection
display_name : Carbon Black Facebook ThreatExchange
display_name : Carbon Black Known IOCs Feed
display_name : Carbon Black SANS
display_name : Carbon Black TOR
display_name : Cb Inspection
display_name : Living Off The Land Drivers
display_name : ThreatConnect Carbon Black Community
display_name : ATT&CK Framework
(venv) zeek@zeek-ubuntu:~/test3.12$
|
csawan-vmware
approved these changes
May 31, 2024
avanbrunt-cb
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the ticket or issue number?
Ticket Number: CRE-18007
Issue Number: N/A
Pull Request Description
Details in CRE
Does this introduce a breaking change?
Need Review
How Has This Been Tested?
Manually.
Other information:
It does seem, python 3.6.9 does not work out, issue with deserializing protobufs
3.7 worked out without any changes
3.12 fail to recognize cbapi.six.moves; Chaning six.py to latest from https://raw.githubusercontent.com/benjaminp/six/master/six.py helped the situation.
I did try to add back all #noqa comment back.
There was an EXPLICIT change that is now overridden, may need additional attention 9ab1930