Skip to content

Ability to obtain just the SVG #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ability to obtain just the SVG #68

wants to merge 1 commit into from

Conversation

Venemo
Copy link

@Venemo Venemo commented Jul 31, 2014

I've added some convenience methods to just obtain the SVG but without drawing it to a canvas. I think this may be beneficial to other people too.

@cburgmer
Copy link
Owner

Thanks for the pull request.

I did change a few things today, so this will not merge anymore. But I feel the general change could make it into the library.

I think the difficulty here is moving the existing bits around in a sane way to make the final conversion to an HTML image object optional. This code could move "up" the call stack, so that render.js only deals with creating the svg.

@cburgmer
Copy link
Owner

cburgmer commented Nov 1, 2014

I have changed the return value to also contain the internal SVG representation. See https://github.com/cburgmer/rasterizeHTML.js/wiki/API#return-value. Let me know if that works for you!

I did not want to provide another set of 3 functions for what I believe is a corner case (I have yet to understand in which situations the SVG can be helpful).

The solution I chose not only returns the svg though, but also makes sure to load it as an Img object. In case the SVG is invalid, some browsers will make rasterizehtml fail.

For the use cases that only need the SVG I hope the loading as an image does not pose a performance issue.

@Venemo
Copy link
Author

Venemo commented Nov 2, 2014

Why the need for SVG? Some browsers can't render an SVG to a canvas, so the idea was to produce the SVG and send it to the server for rendering.

Unfortunately we had other issues with this approach so we ended up in a different direction.

@Venemo Venemo closed this Nov 2, 2014
@cburgmer
Copy link
Owner

cburgmer commented Nov 2, 2014

Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants