Adds extra validation tests for Parameters #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "testItValidatesSchemaAndContentCombination" checks that both "content" and "schema" cannot be present - "testItValidatesSupportedSerializationStyles" checks that only certain serialization styles supported for each Parameter type.
|
I am not sure why the CI failed... |
cebe
requested changes
Mar 6, 2020
src/spec/Parameter.php
Outdated
| 'header' => ['simple'], | ||
| 'cookie' => ['form'], | ||
| ]; | ||
| if (! in_array($this->style, $supportedSerializationStyles[$this->in])) { |
There was a problem hiding this comment.
$supportedSerializationStyles[$this->in] may not be set. An isset() check should be made before this.
Co-Authored-By: Carsten Brandt <mail@cebe.cc>
Co-Authored-By: Carsten Brandt <mail@cebe.cc>
cebe
approved these changes
Mar 6, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR is here.
I am working on validation for incoming HTTP requests, containing serialized parameters: thephpleague/openapi-psr7-validator#2
It looks like this package should be responsible for validating serialization styles defined in the specifications. It should prevent wrong styles chosen. So the abovementioned package can safely rely on the specification to use a correct style for deserialization.
New tests in
ParameterTest.php:testItValidatesSchemaAndContentCombinationchecks that both "content" and "schema" cannot be presenttestItValidatesSupportedSerializationStyleschecks that only certain serialization styles supported for each Parameter type.testItValidatesContentCanHaveOnlySingleKeyenforces this rule: