Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Set ccollapse height to auto on enter complete, unless finalHeight wa… #384

Merged
merged 2 commits into from
Feb 7, 2021
Merged

fix: Set ccollapse height to auto on enter complete, unless finalHeight wa… #384

merged 2 commits into from
Feb 7, 2021

Conversation

IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Feb 4, 2021 •
edited
Loading

Fixes #383. (Also a small fix to the CAccordion storyblock)

Motivation and Context

Sets CCollapse to height: auto when enter is complete, unless finalHeight prop was specified

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 217b85e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 4, 2021

@IHIutch is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@IHIutch
Copy link
Contributor Author

IHIutch commented Feb 4, 2021

Let me know what you think, happy to update

@vercel
Copy link

vercel bot commented Feb 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/bn4rftao1
✅ Preview: https://chakra-ui-vue-git-fork-ihiutch-update-collapse.chakra-ui.now.sh

@codebender828 codebender828 changed the title Set ccollapse height to auto on enter complete, unless finalHeight wa… fix: Set ccollapse height to auto on enter complete, unless finalHeight wa… Feb 7, 2021
@codebender828 codebender828 self-assigned this Feb 7, 2021
@codebender828 codebender828 self-requested a review February 7, 2021 07:25
codebender828
codebender828 approved these changes Feb 7, 2021
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IHIutch

@codebender828 codebender828 merged commit 58daec4 into chakra-ui:develop Feb 7, 2021
@IHIutch IHIutch deleted the update-collapse branch February 7, 2021 13:45
@codebender828 codebender828 mentioned this pull request Mar 14, 2021
Merged
8 tasks
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codebender828 codebender828 codebender828 approved these changes

Assignees

@codebender828 codebender828

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set accordion "CCollapse" height to auto on animation end
2 participants
@IHIutch @codebender828