Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix(docs): add pt and pl in navbar instead of using css file #394

Merged
merged 3 commits into from
Mar 14, 2021

Conversation

carwack
Copy link
Collaborator

@carwack carwack commented Mar 4, 2021

Description

After the logging of this issue in Discord I tried to fix it.
It turns out that the padding gets overwritten by the .css file when the Nuxt project is built.
So I added the padding on the Charka Component CBox itself, so it has the highest priority for css styling.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@carwack carwack added type: bug 🐛 Something isn't working type: documentation 📚 Improvements or additions to documentation labels Mar 4, 2021
@carwack carwack requested a review from codebender828 March 4, 2021 11:09
@carwack carwack self-assigned this Mar 4, 2021
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2021

⚠️ No Changeset found

Latest commit: 40e8a82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 4, 2021

@carwack is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/H895bAABh8Q4145CLUnrDo69hDqV
✅ Preview: https://chakra-ui-vue-git-fork-carwack-fix-fix-styling-navbar-chakra-ui.vercel.app

[Deployment for 40e8a82 canceled]

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @carwack

@vercel vercel bot temporarily deployed to Preview – chakra-ui-vue March 14, 2021 08:41 Inactive
@codebender828 codebender828 merged commit a1f47dd into chakra-ui:develop Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug 🐛 Something isn't working type: documentation 📚 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants