Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Add position: relative to switch label #396

Merged
merged 4 commits into from
Mar 14, 2021
Merged

fix: Add position: relative to switch label #396

merged 4 commits into from
Mar 14, 2021

Conversation

IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Mar 6, 2021

Description

Adds position: relative to the CSwitch <label>

Motivation and Context

Fixes #354 and should prevent unexpected interactions with other elements on a page due to the position: absolute on the <input />

How Has This Been Tested?

In browser; Storybook

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d05d8a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 6, 2021

@IHIutch is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@IHIutch
Copy link
Contributor Author

IHIutch commented Mar 6, 2021

I also noticed setting display to inline-flex gets rid of that extra bit of empty space at the bottom of the switch component. But I wasn't sure if that fits the scope of this bug/PR...

@IHIutch IHIutch changed the title Add position: relative to switch label fix: Add position: relative to switch label Mar 6, 2021
@vercel
Copy link

vercel bot commented Mar 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/oydjKwnBpbga7KtZWeqzpWN1uvh3
✅ Preview: https://chakra-ui-vue-git-fork-ihiutch-fix-switch-overflow-chakra-ui.vercel.app

[Deployment for d05d8a4 canceled]

codebender828
codebender828 reviewed Mar 14, 2021
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IHIutch ! 🎉

@codebender828 codebender828 self-requested a review March 14, 2021 08:50
@vercel vercel bot temporarily deployed to Preview – chakra-ui-vue March 14, 2021 08:58 Inactive
@codebender828 codebender828 merged commit 106a7ff into chakra-ui:develop Mar 14, 2021
@codebender828 codebender828 mentioned this pull request Mar 14, 2021
Merged
8 tasks
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codebender828 codebender828 codebender828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Huge White Space at End of Scroll
2 participants
@IHIutch @codebender828