Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Deeply nested aspect ratio #398

Merged
merged 3 commits into from
Mar 14, 2021
Merged

fix: Deeply nested aspect ratio #398

merged 3 commits into from
Mar 14, 2021

Conversation

IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Mar 7, 2021 •
edited
Loading

Let's renders children placed inside CAspectRatioBox

Description

Fixes a bug where deeply nested children didn't render in CAspectRatioBox. Fixes #392

How Has This Been Tested?

Created tests to check if CAspectRatioBox has 1 child element and to check if CAspectRatioBox renders a deeply nested element

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 77594d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 7, 2021

@IHIutch is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@philwolstenholme
Copy link

Thanks for this, the deploy preview looks good: https://deploy-preview-398--chakra-ui-vue.netlify.app/?path=/story/ui-aspectratiobox--nested-elements

@vercel
Copy link

vercel bot commented Mar 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/FpVhWjXKRkB5B2q3QxRa13S4sqRL
✅ Preview: https://chakra-ui-vue-git-fork-ihiutch-fix-nested-aspect-ratio-8eba33.vercel.app

codebender828
codebender828 approved these changes Mar 14, 2021
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this @IHIutch !

Thanks for this contribution 🎉

@codebender828 codebender828 merged commit 71512a4 into chakra-ui:develop Mar 14, 2021
@codebender828
Copy link
Collaborator

@all-contributors please add @IHIutch for code, bugs and ideas

@allcontributors allcontributors bot mentioned this pull request Mar 14, 2021
Merged
@allcontributors
Copy link
Contributor

@codebender828

I've put up a pull request to add @IHIutch! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codebender828 codebender828 codebender828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CBox used inside CAspectRatioBox has no children nodes/content when rendered in the DOM
3 participants
@IHIutch @philwolstenholme @codebender828