Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: img src attr #446

Merged
merged 11 commits into from
Jun 14, 2021
Merged

fix: img src attr #446

merged 11 commits into from
Jun 14, 2021

Conversation

codebender828
Copy link
Collaborator

@codebender828 codebender828 commented Jun 14, 2021 •
edited
Loading

Description

Closes #445

Motivation and Context

Fixes issue where undefined is assigned to the CImage src OR srcset attributes

How Has This Been Tested?

https://codesandbox.io/s/chakra-ui-vue-0x-starter-template-forked-97cbk?file=/src/App.vue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 737631e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chakra-ui/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codebender828 codebender828 changed the title Fix/img src attr fix: img src attr Jun 14, 2021
@codebender828 codebender828 requested review from carwack and peoray June 14, 2021 07:55
@vercel
Copy link

vercel bot commented Jun 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/2bALozJ9BWSRjVmfrsSSDv3Axoq3
✅ Preview: https://chakra-ui-vue-git-fix-img-src-attr-chakra-ui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 737631e:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration
Chakra UI Vue (0.X) Starter Template (forked) PR

@codebender828 codebender828 merged commit ae1d19e into develop Jun 14, 2021
@codebender828 codebender828 mentioned this pull request Jun 14, 2021
Merged
8 tasks
@github-actions github-actions bot mentioned this pull request Jun 14, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carwack carwack Awaiting requested review from carwack

@peoray peoray Awaiting requested review from peoray

Assignees

@peoray peoray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CImage not working in Nuxt project. Src not showing in image.
2 participants
@codebender828 @peoray