Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: Include all position values in CToast #517

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: Include all position values in CToast #517

merged 1 commit into from
Jan 31, 2022

Conversation

t-buss
Copy link
Contributor

@t-buss t-buss commented Jan 26, 2022

Refering to https://github.com/codebender828/breadstick#-using-different-positions, the type definition of CToast does not include all options.

Description

Include all position values in CToast

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@t-buss
Include all position values in CToast
c3dc44c 
Refering to https://github.com/codebender828/breadstick#-using-different-positions, the type definition of CToast does not include all options.
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022

⚠️ No Changeset found

Latest commit: c3dc44c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 26, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/8E3tpiaSRPJfQN4n5S27zHLy1Vea
✅ Preview: https://chakra-ui-vue-git-fork-t-buss-patch-2-chakra-ui.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3dc44c:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@codebender828 codebender828 self-requested a review January 31, 2022 16:05
codebender828
codebender828 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @t-buss

@codebender828 codebender828 merged commit f4e9f00 into chakra-ui:develop Jan 31, 2022
@t-buss t-buss deleted the patch-2 branch March 15, 2022 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@codebender828 codebender828 codebender828 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-buss @codebender828