Skip to content

Support typescript 5.2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Sep 25, 2023
Merged

Support typescript 5.2 #41

merged 25 commits into from
Sep 25, 2023

Conversation

carlansley
Copy link
Contributor

@carlansley carlansley commented Jul 6, 2023

Fixes #40.

Now a major update, because assumes publishing is done with builder. the good news is that tsconfig.json is now just:

{
  "extends": "@checkdigit/typescript-config"
}

@carlansley carlansley self-assigned this Aug 10, 2023
@carlansley
Copy link
Contributor Author

Waiting on typescript-eslint/typescript-eslint#7155 to get rid of lint warning

@carlansley carlansley marked this pull request as ready for review August 29, 2023 17:45
@carlansley carlansley added MAJOR and removed MINOR labels Aug 30, 2023
le-cong
le-cong previously approved these changes Aug 31, 2023
Copy link

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one little thing I am not sure about. it's probably not an issue.

adcreare
adcreare previously approved these changes Aug 31, 2023
Copy link

@adcreare adcreare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlansley carlansley dismissed stale reviews from adcreare and le-cong via d1bb557 September 5, 2023 00:07
@carlansley carlansley requested a review from le-cong September 5, 2023 00:09
@carlansley carlansley requested a review from adcreare September 5, 2023 00:09
adcreare
adcreare previously approved these changes Sep 5, 2023
Copy link

@adcreare adcreare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ramaghanta
ramaghanta previously approved these changes Sep 5, 2023
@carlansley carlansley dismissed stale reviews from ramaghanta and adcreare via e6cd10e September 6, 2023 19:43
le-cong
le-cong previously approved these changes Sep 6, 2023
Copy link

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

le-cong
le-cong previously approved these changes Sep 19, 2023
Copy link

@ramaghanta ramaghanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change

@@ -372,6 +372,7 @@ describe('test builder', () => {
assert.equal(output2.default.default, 'worldworld');
});

// file.only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

le-cong
le-cong previously approved these changes Sep 25, 2023
Copy link

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@ramaghanta ramaghanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Beta Published - Install Command: npm install @checkdigit/typescript-config@5.0.0-PR.41-9b87

Copy link

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@adcreare adcreare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

✅ PR review status - All reviews completed and approved!

@carlansley carlansley merged commit 9d53581 into main Sep 25, 2023
@carlansley carlansley deleted the typescript-5.2 branch September 25, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Typescript 5.2
4 participants