Support for TypeScript 5.8 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires typescript-eslint/typescript-eslint#10884 to be resolved before publishing. |
le-cong
reviewed
Mar 3, 2025
src/compile.spec.ts
Outdated
| [`thing.ts`]: `export const hello = 'world';`, | ||
| }; | ||
|
|
||
| const exportDefaultFunctionModule = { | ||
| [`index.ts`]: `export default function () { return 'hello world' }\n`, | ||
| [`export-default=function-module.ts`]: `export default function () { return 'hello world' }\n`, |
There was a problem hiding this comment.
is this meant to be export-default-function-module?
There was a problem hiding this comment.
regarding the VSCode thing, moduleResolution is set to bundler and there is no change to this vs the prior version. Not sure why this wasn't an error before. Regardless, I can't think of a reason not to just set noEmit to true, since we never generate code using tsc directly. Try this out, hopefully makes VSCode happy.
|
Beta Published - Install Command: |
le-cong
approved these changes
Mar 3, 2025
|
✅ PR review status - All reviews completed and approved! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than the obvious (updating to TypeScript 5.8), the following changes were made:
noUncheckedSideEffectImportsesbuildwhere there was a difference in behavior between macOS and Linuxjest, only usenode:testrunner