Swap out Brython for RustPython #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything seems to be working except for the spritesheet/ |
coolreader18
commented
Mar 9, 2019
src/nico/src/nico/store.js
Outdated
|
|
||
| const { language } = state | ||
|
|
||
| if (!state.mars) { |
There was a problem hiding this comment.
The problem is here; I have it only initialize mars once so that listeners don't get added multiple times for each initMars call, so the sprites getter that changes for each run call isn't updated in the context of initMars.
|
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a PR RustPython/RustPython#616 that would add properties to the syntax error returned so that there would be an underline in the editor, but that's not in yet.