Skip to content

adr: plugin: Report exceptions from javascript programs #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025

Conversation

ekaitz-zarraga
Copy link
Contributor

@ekaitz-zarraga ekaitz-zarraga commented Jul 19, 2025

Fixes #711

@ekaitz-zarraga ekaitz-zarraga marked this pull request as draft July 19, 2025 18:30
@ekaitz-zarraga ekaitz-zarraga changed the title WIP: adr: Report exceptions from custom ADR programs adr: Report exceptions from custom ADR programs Jul 20, 2025
@ekaitz-zarraga ekaitz-zarraga changed the title adr: Report exceptions from custom ADR programs adr: plugin: Report exceptions from javascript programs Jul 20, 2025
@ekaitz-zarraga ekaitz-zarraga marked this pull request as ready for review July 20, 2025 13:17
@brocaar
Copy link
Contributor

brocaar commented Jul 22, 2025

Hi @ekaitz-zarraga thanks for working on this. There are some formatting errors in the tests. Could you take a look at these?

@ekaitz-zarraga
Copy link
Contributor Author

Sorry @brocaar I'm not a rust programmer, I just did what looked better for me.

I hope 26f0b80 fixes the formatting errors.

@brocaar brocaar merged commit e26a6e0 into chirpstack:master Aug 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR scripts: no exception reporting
2 participants