Randomize layout regression test addition #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to resolve the identification of the RandomizeLayout attribute to the regression test suite. Without this, running "make clang-test" will result in a failure due to it identifying an attribute but not having it included in: ../clang/test/Misc/pragma-attribute-supported-attributes-list.test. This protects against the addition/removal of attributes.
added 2 commits
February 22, 2019 00:51
This commit is to resolve the identification of the RandomizeLayout attribute to the regression test suite. Without this, running "make clang-test" will result in a failure due to it identifying an attribute but not having it included in: ../clang/test/Misc/pragma-attribute-supported-attributes-list.test. This protects against the addition/removal of attributes. Co-authored-by:Nikk <nforbus@pdx.edu>
…thub.com/clang-randstruct/llvm-project into RandomizeLayout_Regression_Test_Addition
connorkuehl
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
👍 Nice job!
[100%] Running the Clang regression tests
llvm-lit: /home/kuehlcon/llvm-project/llvm/utils/lit/lit/llvm/config.py:337: note: using clang: /home/kuehlcon/llvm-project/build/bin/clang
Testing Time: 419.34s
Expected Passes : 14089
Expected Failures : 19
Unsupported Tests : 62
[100%] Built target check-clang
Scanning dependencies of target clang-test
[100%] Built target clang-test
jcantrell
approved these changes
Feb 25, 2019
connorkuehl
added a commit
that referenced
this pull request
Feb 25, 2019
tim-pugh
pushed a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you enter into the
buildfolder and runmake clang-testyou are executing the clang regression test suite.This addition fixes the test suite failing with the addition of our attribute
RandomizeLayoutby modifying the filellvm-project/clang/test/Misc/pragma-attribute-supported-attributes-list.testand adding our attribute to the run of checked attributes.You must add additions in alphabetical order, hence it showing up in the middle.