Skip to content

chore(clerk-js): Rename org session task key to select-organization #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

chore(clerk-js): Rename org session task key to select-organization #6372

merged 1 commit into from
Jul 22, 2025

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jul 21, 2025 •
edited by coderabbitai bot
Loading

Description

Waiting on API changes to be deployed first before merging this PR. https://github.com/clerk/clerk_go/pull/12757

It renames the session task key and all checks against it according to the latest FAPI nomenclature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Refactor
    • Renamed the organization selection task key and related route from "org" and "add-organization" to "select-organization" for improved clarity and consistency in the user interface.
  • Tests
    • Updated test cases to align with the new task key and navigation path for organization selection.

@LauraBeatris LauraBeatris self-assigned this Jul 21, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c819cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 5:44pm

@LauraBeatris LauraBeatris marked this pull request as ready for review July 21, 2025 23:19
@LauraBeatris LauraBeatris requested a review from a team July 21, 2025 23:19
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 21, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

This change updates the session task key related to organization handling throughout the codebase. The key value 'org' is renamed to 'select-organization' in the SessionTask interface, the INTERNAL_SESSION_TASK_ROUTE_BY_KEY mapping, and all related usages, including test mocks and route paths. The corresponding route value is also updated from 'add-organization' to 'select-organization'. All affected files are modified to reference the new key and route. No other logic, structure, or public API signatures are altered beyond this renaming.

Estimated code review effort

2 (~15 minutes)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3658b7 and c819cdc.

📒 Files selected for processing (5)
  • .changeset/wicked-meals-travel.md (1 hunks)
  • packages/clerk-js/src/core/__tests__/clerk.test.ts (3 hunks)
  • packages/clerk-js/src/core/sessionTasks.ts (1 hunks)
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx (1 hunks)
  • packages/types/src/session.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • .changeset/wicked-meals-travel.md
  • packages/clerk-js/src/ui/components/SessionTasks/index.tsx
  • packages/types/src/session.ts
  • packages/clerk-js/src/core/sessionTasks.ts
  • packages/clerk-js/src/core/tests/clerk.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Build Packages
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LauraBeatris LauraBeatris reopened this Jul 22, 2025
@LauraBeatris LauraBeatris mentioned this pull request Jul 22, 2025
Merged
9 tasks
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 22, 2025 •
edited
Loading

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6372

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6372

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6372

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6372

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6372

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6372

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6372

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6372

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6372

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6372

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6372

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6372

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6372

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6372

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6372

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6372

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6372

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6372

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6372

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6372

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6372

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6372

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6372

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6372

commit: c819cdc

@LauraBeatris
Copy link
Member Author

Tests are failing since we aren't expecting this new key from FAPI - it'll resolve once we deploy it.

@LauraBeatris LauraBeatris force-pushed the laura/rename-task-key branch from c4a76c9 to e43598d Compare July 22, 2025 16:19
@LauraBeatris LauraBeatris force-pushed the laura/rename-task-key branch from e43598d to efddcd0 Compare July 22, 2025 16:26
@LauraBeatris LauraBeatris enabled auto-merge (squash) July 22, 2025 16:58
@LauraBeatris LauraBeatris force-pushed the laura/rename-task-key branch from efddcd0 to c3658b7 Compare July 22, 2025 17:27
@LauraBeatris LauraBeatris force-pushed the laura/rename-task-key branch from c3658b7 to c819cdc Compare July 22, 2025 17:43
@LauraBeatris LauraBeatris merged commit 43ea069 into main Jul 22, 2025
79 of 84 checks passed
@LauraBeatris LauraBeatris deleted the laura/rename-task-key branch July 22, 2025 18:51
@clerk-cookie clerk-cookie mentioned this pull request Jul 22, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Aug 6, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iagodahlem iagodahlem iagodahlem approved these changes

Assignees

@LauraBeatris LauraBeatris

Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LauraBeatris @iagodahlem @clerk-cookie