fix(clerk-js): Update `touchSession` option to only affect window focus events #6444

LauraBeatris · 2025-07-30T20:26:35Z

Description

This PR moves touchSession check to the focus window event when calling #touchCurrentSession, fixing issues where #touchCurrentSession got disabled within setActive calls for behaviors such as selecting organizations or multi-session handling.

CleanShot.2025-07-30.at.17.30.24.mp4

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Bug Fixes
- Corrected session touch behavior so disabling it only affects window focus events; session updates during switching or organization selection now function properly.
Tests
- Enhanced test coverage to verify session touch behavior with various configuration settings.

changeset-bot · 2025-07-30T20:26:39Z

🦋 Changeset detected

Latest commit: 0cd2552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-07-30T20:26:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2025 9:20pm

coderabbitai · 2025-07-30T20:35:18Z

📝 Walkthrough

Walkthrough

This change updates the @clerk/clerk-js package to refine the behavior of the touchSession option. The patch ensures that the touchSession flag only affects session touching on window focus events, rather than globally disabling session touching in all scenarios. The implementation moves the touchSession check to the window focus event handler, allowing session touching to occur during other operations such as setActive(). Corresponding tests are refactored and expanded to verify the updated logic, particularly distinguishing between window focus and other session-related actions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd4d233 and 0cd2552.

📒 Files selected for processing (3)

.changeset/yellow-radios-stop.md (1 hunks)
packages/clerk-js/src/core/__tests__/clerk.test.ts (1 hunks)
packages/clerk-js/src/core/clerk.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

.changeset/yellow-radios-stop.md

🚧 Files skipped from review as they are similar to previous changes (2)

packages/clerk-js/src/core/clerk.ts
packages/clerk-js/src/core/tests/clerk.test.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: semgrep-cloud-platform/scan
GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: semgrep/ci
GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-07-30T20:38:21Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6444

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6444

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6444

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6444

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6444

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6444

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6444

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6444

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6444

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6444

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6444

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6444

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6444

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6444

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6444

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6444

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6444

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6444

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6444

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6444

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6444

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6444

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6444

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6444

commit: 0cd2552

jacekradko

👍🏼

LauraBeatris self-assigned this Jul 30, 2025

vercel bot deployed to Preview July 30, 2025 20:26 View deployment

clerk-cookie added the clerk-js label Jul 30, 2025

LauraBeatris force-pushed the laura/fix-touch-session-with-set-active branch 2 times, most recently from d3d4b04 to 9eccb6d Compare July 30, 2025 20:28

LauraBeatris requested review from brkalow, nikosdouvlis and a team July 30, 2025 20:29

vercel bot deployed to Preview July 30, 2025 20:29 View deployment

LauraBeatris marked this pull request as ready for review July 30, 2025 20:32

Move touchSession check to window focus event

f98c6bc

LauraBeatris force-pushed the laura/fix-touch-session-with-set-active branch from 9eccb6d to 672d171 Compare July 30, 2025 20:34

vercel bot deployed to Preview July 30, 2025 20:35 View deployment

LauraBeatris force-pushed the laura/fix-touch-session-with-set-active branch from 672d171 to dd4d233 Compare July 30, 2025 20:51

vercel bot deployed to Preview July 30, 2025 20:52 View deployment

Add changeset

0cd2552

LauraBeatris force-pushed the laura/fix-touch-session-with-set-active branch from dd4d233 to 0cd2552 Compare July 30, 2025 21:19

vercel bot deployed to Preview July 30, 2025 21:20 View deployment

jacekradko approved these changes Jul 31, 2025

View reviewed changes

nikosdouvlis approved these changes Aug 1, 2025

View reviewed changes

LauraBeatris merged commit 4602f18 into main Aug 1, 2025
36 checks passed

LauraBeatris deleted the laura/fix-touch-session-with-set-active branch August 1, 2025 12:29

clerk-cookie mentioned this pull request Aug 1, 2025

ci(repo): Version packages #6454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(clerk-js): Update `touchSession` option to only affect window focus events #6444

fix(clerk-js): Update `touchSession` option to only affect window focus events #6444

Uh oh!

LauraBeatris commented Jul 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

jacekradko left a comment

Uh oh!

Uh oh!

Uh oh!

fix(clerk-js): Update touchSession option to only affect window focus events #6444

fix(clerk-js): Update touchSession option to only affect window focus events #6444

Uh oh!

Conversation

LauraBeatris commented Jul 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacekradko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fix(clerk-js): Update `touchSession` option to only affect window focus events #6444

fix(clerk-js): Update `touchSession` option to only affect window focus events #6444

LauraBeatris commented Jul 30, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jul 30, 2025 •

edited

Loading

vercel bot commented Jul 30, 2025 •

edited

Loading

coderabbitai bot commented Jul 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jul 30, 2025 •

edited

Loading