Fix code scanning alert no. 2: SQL query built from user-controlled sources #11
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ources Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/clever-org-name/rudy750-advanced-security-python/security/code-scanning/2
To fix the problem, we should use parameterized queries instead of directly concatenating user input into the SQL query strings. Parameterized queries ensure that user input is properly escaped and quoted, preventing SQL injection attacks.
cursor.executecalls with parameterized queries.%s) in the SQL query strings and pass the user-provided values as a second argument to thecursor.executemethod.readparameter is handled correctly, as it is converted to a boolean.Suggested fixes powered by Copilot Autofix. Review carefully before merging.