Handle conversion of generic-alias and union-type types in ->jvm #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #250.
Some python types (in particular
GenericAliasandUnion) cannot be handled by the default->jvmhandler.Note on tests: The only way I could find to instantiate an object of type
types.UnionTypefor testing is directly with python syntax and the|operator. I don't know of a way to test objects created via syntax without creating global variables in the python interpreter (e.g. withrun-simple-string). For that reason, I've left the test for this out for now. I have tested by hand. Suggestions for good approaches to this welcome.Note:
types.UnionTypeis not the same astyping.Union, which can be used via__get_item__to produces objects of typetyping._UnionGenericAlias.