Skip to content

Handle unloadable classes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2023
Merged

Handle unloadable classes #10

merged 1 commit into from
Aug 18, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Aug 18, 2023

Fixes #9

n.b., this is a pretty extreme edge case, so it doesn't matter that much, however I find it worthwhile to avoid displaying noisy internal stracktraces to the end user.

Cheers - V

@vemv vemv requested review from r0man and bbatsov August 18, 2023 10:58
r0man
r0man approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@r0man r0man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vemv, LGTM. Thanks for fixing this.

@vemv
Copy link
Member Author

vemv commented Aug 18, 2023

🍻

@vemv vemv merged commit 140b4c1 into master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0man r0man r0man approved these changes

@bbatsov bbatsov Awaiting requested review from bbatsov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call to Orchard's resolve-class can fail
2 participants
@vemv @r0man