Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2019

Changed content type and made optional parameters optional as detailed in the cloudevents spec.

Julia Huang added 2 commits June 11, 2019 14:48
Signed-off-by: Julia Huang <julia@playground.global>
Signed-off-by: Julia Huang <julia@playground.global>
@fabiojose
Copy link
Contributor

@playground-julia Please check the CI, some tests are failing.

@ghost
Copy link
Author

ghost commented Jun 11, 2019

I'm going to merge changes from PR #14 with this so that the tests will pass. I'm going to close PR #14 as well because I didn't sign it.

…ssing

Signed-off-by: Julia Huang <julia@playground.global>
@ghost
Copy link
Author

ghost commented Jun 11, 2019

@fabiojose tests are passing now.

Copying comments from PR #14 over. I saw line 14. I don't think it's useless because the config object is being changed in line 6/7. That's what was causing npm test to fail...

@fabiojose
Copy link
Contributor

@playground-julia Could you open an issue for registration and link this PR there?

@fabiojose fabiojose added type/bug Something isn't working good first issue Good for newcomers labels Jun 11, 2019
@ghost
Copy link
Author

ghost commented Jun 11, 2019

Issued and linked!

@fabiojose fabiojose merged commit ac6cf27 into cloudevents:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant