Validate extension names #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
|
While #229 is also related, i'm going to split them into 2 PRs |
lance
reviewed
Jul 14, 2020
There was a problem hiding this comment.
LGTM - surprised there weren't more changes required to the tests. There are a couple of places in the examples that should be updated as well.
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/payload/v1/structured-event-1.json#L11
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/payload/v1/structured-event-2.json#L9
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/payload/v03/structured-event-1.json#L11
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/payload/v03/structured-event-2.json#L10
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/typescript-ex/src/index.ts#L14
- https://github.com/cloudevents/sdk-javascript/blob/master/examples/typescript-ex/src/index.ts#L40
I guess you wrote them perfectly :) for the examples, yea, we are going to need to update them. which might be good to do in its own PR |
grant
approved these changes
Jul 14, 2020
Sounds good. I've added #249 |
lance
approved these changes
Jul 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates the extension names based on the spec, https://github.com/cloudevents/spec/blob/master/spec.md#attribute-naming-convention
fixes #228
Signed-off-by: Lucas Holmquist lholmqui@redhat.com