Skip to content

lib: change Receiver#accept() to be static Receiver.accept #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

lib: change Receiver#accept() to be static Receiver.accept #271

merged 1 commit into from
Jul 24, 2020

Conversation

lance
Copy link
Member

@lance lance commented Jul 24, 2020

Note that I did not add a third Protocol parameter to Receiver.accept since
that would not currently be used. It's non-breaking to add a third parameter
in the future once additional protocols are supported.

Fixes: #266
Fixes: #261

BREAKING CHANGE

@lance
lib: change Receiver#accept() to be static Receiver.accept
76da125 
Note that I did not add a third `Protocol` parameter to `Receiver.accept` since
that would not currently be used. It's non-breaking to add a third parameter
in the future once additional protocols are supported.

Fixes: cloudevents#266
Fixes: cloudevents#261

BREAKING CHANGE

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested review from a team, danbev, grant, helio-frota and lholmquist and removed request for a team July 24, 2020 14:18
@lance lance added module/lib Related to the main source code module/transport/http Issues related to the HTTP transport protocol implementation type/enhancement New feature or request version/3.x Issues related to the 3.0 release of this library labels Jul 24, 2020
@lance lance mentioned this pull request Jul 24, 2020
Closed
@lholmquist lholmquist merged commit 9ae32c7 into cloudevents:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@danbev danbev Awaiting requested review from danbev

@helio-frota helio-frota Awaiting requested review from helio-frota

+1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
module/lib Related to the main source code module/transport/http Issues related to the HTTP transport protocol implementation type/enhancement New feature or request version/3.x Issues related to the 3.0 release of this library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Concept of Multiple Protocols within HTTP 1 line parse CloudEvent from HTTP Request
3 participants
@lance @grant @lholmquist