Skip to content

Fix minor import problems in README #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

Fix minor import problems in README #374

merged 1 commit into from
Jan 4, 2021

Conversation

aliok
Copy link
Contributor

@aliok aliok commented Dec 21, 2020

Proposed Changes

  • Fix the sample code in README. There are some missing imports for CloudEvent objects

Description

  • Fixes Issue #
  • Version:

@aliok
Fix minor import problems in README
bf1cf9c 
Signed-off-by: Ali Ok <aliok@redhat.com>
lance
lance approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lholmquist lholmquist merged commit ed81483 into cloudevents:main Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@lholmquist lholmquist lholmquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliok @lance @lholmquist