fix: ensure loose validation for isEvent and toEvent #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HTTP.isEvent()` and `HTTP.toEvent()` functions both had some validation code that violated the principle of loose validation when receiving an event over HTTP. As discussed, the validation should be managed by the receiver in this case with `event.validate()` Signed-off-by: Lance Ball <lball@redhat.com>
|
@lholmquist I was hoping to get this in before 4.0.1 but 🤷. Once this is out, I can replace all of this with |
lholmquist
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HTTP.isEvent()andHTTP.toEvent()functions both had some validationcode that violated the principle of loose validation when receiving an
event over HTTP. As discussed, the validation should be managed by the
receiver in this case with
event.validate()Signed-off-by: Lance Ball lball@redhat.com