feat!: remove node 12 and node 14 #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lance ^^ |
Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023 Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
3e4e5e2 to
a9da0a1
Compare
|
@lholmquist it looks like the error message thrown with JSON parsing changed in v20. Can you also modify the expectation on line 59 of expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError); |
04756aa to
79edf38
Compare
|
@lance updated and looks like it passes now. Hopefully this also generates a release pr 🤞 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023
This is a major version bump