from_http should expect headers as first parameter #103

cumason123 · 2020-08-13T22:33:23Z

Expected Behavior

def from_http(
    headers: typing.Dict[str, str],
    data: typing.Union[str, bytes],
    data_unmarshaller: types.UnmarshallerType = None,
):

This order of parameters would make cloudevents.http.from_http more consistent with the other methods which either expect some header like object first, or return headers followed by data

Actual Behavior

def from_http(
    data: typing.Union[str, bytes],
    headers: typing.Dict[str, str],
    data_unmarshaller: types.UnmarshallerType = None,
)

cumason123 mentioned this issue Aug 17, 2020

from_http now takes headers as first arg #110

Merged

cumason123 closed this as completed Aug 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

from_http should expect headers as first parameter #103

from_http should expect headers as first parameter #103

cumason123 commented Aug 13, 2020

from_http should expect headers as first parameter #103

from_http should expect headers as first parameter #103

Comments

cumason123 commented Aug 13, 2020

Expected Behavior

Actual Behavior