Breaking Changes introduced in version 1.6.0 #190
Comments
|
@JP-Dhabolt I will look into that |
sasha-tkachev
added a commit
to sasha-tkachev/sdk-python
that referenced
this issue
Aug 22, 2022
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
sasha-tkachev
added a commit
to sasha-tkachev/sdk-python
that referenced
this issue
Aug 22, 2022
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
|
You are correct, |
xSAVIKx
pushed a commit
that referenced
this issue
Aug 25, 2022
* fix: missing to_json import #190 Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> * test: backwards compatability import from http module #190 Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docs: update changelog Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * docs: update changelog Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> * feat: bump version Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Hey @JP-Dhabolt, thx for raising this. The fix is merged already and should be released shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Minor version updates do not introduce breaking changes
Actual Behavior
Minor version updates introduced breaking change.
Steps to Reproduce the Problem
cloudevents~=1.21.6.0, which is minor version updates onlyfrom cloudevents.http import to_json. This is not the only breaking change introduced, just the one that specifically impacted my team.Specifications
It looks like it was #188 that caused the breaking change, based on the Changelog and the history of
cloudevents/http/__init__.py. It looks like the intention was to deprecate some functionality, but by changing the import path, it broke the functionality instead.The text was updated successfully, but these errors were encountered: