Skip to content

SDK must serialize/deserialize binary data to/from data_base64 instead of data #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcBoissonneault opened this issue Mar 23, 2020 · 4 comments · Fixed by #34
Closed

SDK must serialize/deserialize binary data to/from data_base64 instead of data #28

MarcBoissonneault opened this issue Mar 23, 2020 · 4 comments · Fixed by #34
Assignees
@cumason123

Comments

@MarcBoissonneault
Copy link

As mentioned here in the spec the data must be serialize/deserialize to/from data_base64 when the data is determined to be binary.

For serialization examples, see the go implementation, or the C# implementation
For deserialization examples, see the go implementation, the java implementation, or the C# implementation
@MarcBoissonneault MarcBoissonneault changed the title SDK msut serialize/desiralize binary data to/from data_base64 instead on data SDK must serialize/deserialize binary data to/from data_base64 instead on data Mar 23, 2020
@MarcBoissonneault MarcBoissonneault changed the title SDK must serialize/deserialize binary data to/from data_base64 instead on data SDK must serialize/deserialize binary data to/from data_base64 instead of data Mar 23, 2020
@n3wscott
Copy link
Member

this is only true for v1.0

@evankanderson evankanderson mentioned this issue May 8, 2020
Merged
@grant
Copy link
Member

grant commented Jun 26, 2020 •
edited
Loading

The spec isn't super clear with the contradictory examples.
@cumason123 From C#, t looks like the logic is:

if `data_base64` exists:
  base64 decode and store in `data`

I propose we do that.

@cumason123
Copy link
Contributor

@evankanderson @MarcBoissonneault can we close this issue?

@evankanderson
Copy link
Contributor

Yes.

@di di closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cumason123 cumason123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update types and handle data_base64 structured. evankanderson/sdk-python
6 participants
@di @grant @MarcBoissonneault @evankanderson @cumason123 @n3wscott