Exceptions general class #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2020 13:48
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
grant
approved these changes
Aug 19, 2020
cumason123
added a commit
that referenced
this pull request
Aug 19, 2020
* from_http bug None and non dict data bug fixes (#119) * resolving from_http bugs Signed-off-by: Curtis Mason <cumason@google.com> * resolved from_http bugs Signed-off-by: Curtis Mason <cumason@google.com> * nit fix Signed-off-by: Curtis Mason <cumason@google.com> * Exceptions general class (#120) * More edgecase testing Signed-off-by: Curtis Mason <cumason@google.com> * Tested empty object edge cases Signed-off-by: Curtis Mason <cumason@google.com> * test-coverage Signed-off-by: Curtis Mason <cumason@google.com> * Changelog update (#121) Signed-off-by: Curtis Mason <cumason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Changes
Standardized handling edge cases with data objects: [], (), b'', "", None, and {}
Added GenericException, DataMarshallerError and DataUnmarshallerError
One line description for the changelog
Additional exception handling and empty object bug fix