Adding web app tests #13
Conversation
Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
20adb02 to
0972b50
Compare
|
@evankanderson please review. |
| @@ -159,5 +158,4 @@ def MarshalBinary( | |||
| headers["ce-{0}".format(key)] = value | |||
|
|
|||
| data, _ = self.Get("data") | |||
| return headers, io.BytesIO( | |||
| str(data_marshaller(data)).encode("utf-8")) | |||
| return headers, data_marshaller(data) | |||
There was a problem hiding this comment.
This changes the output to be the result of the data_marshaller, rather than enforcing that the data is utf-8 encoded.
Not sure if this is intentional or not.
There was a problem hiding this comment.
my original idea doesn't really work well, so, I think it would be simpler to let people decide what they want to do with the event data.
for instance, if you'd like to get an io.Bytes from marshaller you can do the following:
m.ToRequest(event, lambda x: io.BytesIO(str(x).encode("utf-8")))but forcing them to do things they don't want is a bad idea, though.
cloudevents/sdk/exceptions.py
Outdated
| super().__init__("Invalid CloudEvent class: " | ||
| "'{0}'".format(event_class)) | ||
| super().__init__( | ||
| "Invalid CloudEvent class: " "'{0}'".format(event_class) |
There was a problem hiding this comment.
This is strange -- I'd collapse the " " in this case.
| @@ -35,14 +35,16 @@ def __init__(self, converters: typing.List[base.Converter]): | |||
| :param converters: a list of HTTP-to-CloudEvent-to-HTTP constructors | |||
| :type converters: typing.List[base.Converter] | |||
| """ | |||
| self.__converters = (c for c in converters) | |||
| self.__converters = [c for c in converters] | |||
There was a problem hiding this comment.
D'oh -- I was too clever!
Thanks!
| return response.text(body, headers=hs) | ||
|
|
||
|
|
||
| def test_reusable_marshaller(): |
There was a problem hiding this comment.
This is great, I suspect that just calling .FromRequest 5 times would have caught my bug.
There was a problem hiding this comment.
well, maybe, but 10 is 2 times greater than 5, so we have double-insurance here =)
Signed-off-by: Denis Makogon <denys.makogon@oracle.com>
|
Looks Good To Me (LGTM). |
|
thanks, merging. |
Closes: #12