Skip to content

chore: cleanup codebase and fix flake errors #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 14, 2022
Merged

chore: cleanup codebase and fix flake errors #188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e21f999
deps: `flake8-strict` and `flake8-import-order` are not compatible w…
xSAVIKx Aug 14, 2022
39e9bbf
chore: Cleanup imports and remove obsolete `#noqa`.
xSAVIKx Aug 14, 2022
617dda6
chore: sort imports.
xSAVIKx Aug 14, 2022
657c66c
chore: Define `__all__`
xSAVIKx Aug 14, 2022
5641bb9
chore: Fix licenses and add __all__ to imports.
xSAVIKx Aug 14, 2022
faec87e
chore: Fix formatting
xSAVIKx Aug 14, 2022
9790565
chore: Export `from_http`
xSAVIKx Aug 14, 2022
6f305c3
fix: Do not export functions of other modules from this one.
xSAVIKx Aug 14, 2022
817ef01
chore: Resolve more flake8 errors
xSAVIKx Aug 14, 2022
51213d7
chore: Fix more warnings
xSAVIKx Aug 14, 2022
1ab9b63
docs: add a note in the changelog about the fixes.
xSAVIKx Aug 14, 2022
000a8fb
fix: imports in tests.
xSAVIKx Aug 14, 2022
927fd2a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2022
c49698b
fix: more import fixes.
xSAVIKx Aug 14, 2022
20bb37e
fix: use proper implementations as replacements.
xSAVIKx Aug 14, 2022
00ff8b9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use proper implementations as replacements. 
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
  • Loading branch information
@xSAVIKx
xSAVIKx committed Aug 14, 2022
commit 20bb37e40d1ea251ff8e26173f41c786483bada3
4 changes: 2 additions & 2 deletions cloudevents/http/http_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

@deprecated(
deprecated_in="1.6.0",
details="Use cloudevents.http.to_binary function instead",
details="Use cloudevents.conversion.to_binary function instead",
)
def to_binary(
event: AnyCloudEvent, data_marshaller: types.MarshallerType = None
Expand All @@ -38,7 +38,7 @@ def to_binary(

@deprecated(
deprecated_in="1.6.0",
details="Use cloudevents.http.to_structured function instead",
details="Use cloudevents.conversion.to_structured function instead",
)
def to_structured(
event: AnyCloudEvent,
Expand Down
4 changes: 2 additions & 2 deletions cloudevents/http/json_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from deprecation import deprecated

from cloudevents.abstract import AnyCloudEvent
from cloudevents.conversion import from_json as _moved_from_json
from cloudevents.http.conversion import from_json as _moved_from_json
from cloudevents.conversion import to_json as _moved_to_json
from cloudevents.http import CloudEvent
from cloudevents.sdk import types
Expand All @@ -27,7 +27,7 @@

@deprecated(
deprecated_in="1.6.0",
details="Use cloudevents.http.to_json function instead",
details="Use cloudevents.conversion.to_json function instead",
)
def to_json(
event: AnyCloudEvent,
Expand Down