Skip to content

fix: to_json breaking change #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 25, 2022
Merged

fix: to_json breaking change #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
258af22
fix: missing to_json import #190
sasha-tkachev Aug 22, 2022
67337d3
test: backwards compatability import from http module #190
sasha-tkachev Aug 22, 2022
1130a65
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 22, 2022
6071fd5
docs: update changelog
sasha-tkachev Aug 22, 2022
b0fa880
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 22, 2022
869579a
docs: update changelog
sasha-tkachev Aug 23, 2022
382f45c
feat: bump version
sasha-tkachev Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the 1.6.1 release section and also update the version in the module init.py


## [1.6.1] — 2022-08-18
### Fixed
- Missing `to_json` import. ([#191])


## [1.6.0] — 2022-08-17
### Added
- A new `CloudEvent` optional `pydantic` model class is available in the
Expand Down Expand Up @@ -141,7 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.0.1] - 2018-11-19
### Added
- Initial release

[1.6.1]: https://github.com/cloudevents/sdk-python/compare/1.6.0...1.6.1
[1.6.0]: https://github.com/cloudevents/sdk-python/compare/1.5.0...1.6.0
[1.5.0]: https://github.com/cloudevents/sdk-python/compare/1.4.0...1.5.0
[1.4.0]: https://github.com/cloudevents/sdk-python/compare/1.3.0...1.4.0
Expand Down Expand Up @@ -204,3 +209,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#184]: https://github.com/cloudevents/sdk-python/pull/184
[#186]: https://github.com/cloudevents/sdk-python/pull/186
[#188]: https://github.com/cloudevents/sdk-python/pull/188
[#191]: https://github.com/cloudevents/sdk-python/pull/191
2 changes: 1 addition & 1 deletion cloudevents/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
# License for the specific language governing permissions and limitations
# under the License.

__version__ = "1.6.0"
__version__ = "1.6.1"
2 changes: 2 additions & 0 deletions cloudevents/http/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
to_structured,
to_structured_http,
)
from cloudevents.http.json_methods import to_json # deprecated

__all__ = [
to_binary,
Expand All @@ -34,4 +35,5 @@
is_structured,
to_binary_http,
to_structured_http,
to_json,
]
16 changes: 16 additions & 0 deletions cloudevents/tests/test_backwards_compatability.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,19 @@ def test_util():

def test_event_type():
from cloudevents.http.event_type import is_binary, is_structured # noqa


def test_http_module_imports():
from cloudevents.http import ( # noqa
CloudEvent,
from_dict,
from_http,
from_json,
is_binary,
is_structured,
to_binary,
to_binary_http,
to_json,
to_structured,
to_structured_http,
)