Skip to content

Feat/expose event attributes #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Feat/expose event attributes #195

merged 5 commits into from
Oct 19, 2022

Conversation

xSAVIKx
Copy link
Member

@xSAVIKx xSAVIKx commented Oct 18, 2022

In this PR I have added a read-only get_attributes API to the CloudEvent instances. This allows for glancing at the attributes and their keys without using protected props or other hacky methods.

  • Tests pass
  • Appropriate changes to changelog are included in the PR

Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
@xSAVIKx xSAVIKx added the enhancement New feature or request label Oct 18, 2022
@xSAVIKx xSAVIKx requested a review from a team October 18, 2022 10:42
@xSAVIKx xSAVIKx self-assigned this Oct 18, 2022
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
Copy link

@Klaudioz Klaudioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Klaudioz Klaudioz force-pushed the feat/expose_event_attributes branch from 91bc4e0 to 45ea364 Compare October 18, 2022 21:54
Signed-off-by: Yurii Serhiichuk <savik.ne@gmail.com>
@xSAVIKx xSAVIKx force-pushed the feat/expose_event_attributes branch from 45ea364 to 59e947e Compare October 19, 2022 16:17
Copy link

@Klaudioz Klaudioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Klaudioz Klaudioz merged commit 6648eb5 into main Oct 19, 2022
@Klaudioz Klaudioz deleted the feat/expose_event_attributes branch October 19, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants